[Merged by Bors] - feat: add Mathlib.Tactic.Common, and import#4056
Closed
[Merged by Bors] - feat: add Mathlib.Tactic.Common, and import#4056
Conversation
Contributor
|
Let's try it! I think making all the basic tactics available everywhere would be a real improvement. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 19, 2023
This makes a mathlib4 version of mathlib3's `tactic.basic`, now called `Mathlib.Tactic.Common`, which imports all tactics which do not have significant theory requirements, and then is imported all across the base of the hierarchy. This ensures that all common tactics are available nearly everywhere in the library, rather than having to be imported one-by-one as you need them. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a mathlib4 version of mathlib3's
tactic.basic, now calledMathlib.Tactic.Common, which imports all tactics which do not have significant theory requirements, and then is imported all across the base of the hierarchy.This ensures that all common tactics are available nearly everywhere in the library, rather than having to be imported one-by-one as you need them.