[Merged by Bors] - fix: out-line instance equality proofs in norm_num#4048
Closed
[Merged by Bors] - fix: out-line instance equality proofs in norm_num#4048
Conversation
Member
|
Member
Author
Only the ones that involve a typeclass search that could be resolved in several ways. So for example the |
Member
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 28, 2023
This applies a similar technique as was used for the `ofScientific` norm_num extension to the core field operations. This ensures that lean doesn't try to prove `Add.add (inst := inst1) 1234 56 = Add.add (inst := inst2) 1234 56` by evaluating the addition itself, and instead tries to prove the instances equal and let norm_num do the adding. Reported at #4036 (comment) , although I can't find a test case that doesn't involve the base norm_num implementation because all the core operations on nat are already overridden.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies a similar technique as was used for the
ofScientificnorm_num extension to the core field operations. This ensures that lean doesn't try to proveAdd.add (inst := inst1) 1234 56 = Add.add (inst := inst2) 1234 56by evaluating the addition itself, and instead tries to prove the instances equal and let norm_num do the adding. Reported at #4036 (comment) , although I can't find a test case that doesn't involve the base norm_num implementation because all the core operations on nat are already overridden.