Skip to content

[Merged by Bors] - chore: some simpNF cleanaup after #3414#4033

Closed
kim-em wants to merge 6 commits intomasterfrom
etaExperiment_cleanup4
Closed

[Merged by Bors] - chore: some simpNF cleanaup after #3414#4033
kim-em wants to merge 6 commits intomasterfrom
etaExperiment_cleanup4

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented May 16, 2023

Open in Gitpod

@kim-em kim-em added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels May 16, 2023
jcommelin
jcommelin reviewed May 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link
Copy Markdown

bors bot commented May 16, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em kim-em added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels May 16, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label May 17, 2023
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented May 17, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 17, 2023
bors bot pushed a commit that referenced this pull request May 17, 2023
@kim-em
chore: some simpNF cleanaup after #3414 (#4033)
3d49f21 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: some simpNF cleanaup after #3414 [Merged by Bors] - chore: some simpNF cleanaup after #3414 May 17, 2023
@bors bors bot closed this May 17, 2023
@bors bors bot deleted the etaExperiment_cleanup4 branch May 17, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kim-em @jcommelin