Skip to content

[Merged by Bors] - port: Nat.sqrt extension for norm_num#4027

Closed
kmill wants to merge 6 commits intomasterfrom
kmill_normnum_nat_sqrt
Closed

[Merged by Bors] - port: Nat.sqrt extension for norm_num#4027
kmill wants to merge 6 commits intomasterfrom
kmill_normnum_nat_sqrt

Conversation

@kmill
Copy link
Copy Markdown
Contributor

@kmill kmill commented May 16, 2023


Open in Gitpod

@kmill kmill added the t-meta Tactics, attributes or user commands label May 16, 2023
@kmill
Copy link
Copy Markdown
Contributor Author

kmill commented May 16, 2023

@digama0 Here's a port of your Nat.sqrt extension. Should I be including any porting header for this meta file since it came from the theory folder?

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 16, 2023

I think no need for a porting header.

Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 23, 2023
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 25, 2023
@digama0
Copy link
Copy Markdown
Member

digama0 commented May 27, 2023

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 27, 2023
bors bot pushed a commit that referenced this pull request May 27, 2023
@bors
Copy link
Copy Markdown

bors bot commented May 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title port: Nat.sqrt extension for norm_num [Merged by Bors] - port: Nat.sqrt extension for norm_num May 27, 2023
@bors bors bot closed this May 27, 2023
@bors bors bot deleted the kmill_normnum_nat_sqrt branch May 27, 2023 12:33
Parcly-Taxel added a commit that referenced this pull request Jun 5, 2023
bors bot pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants