Skip to content

[Merged by Bors] - fix: correct names of LinearOrder decidable fields#4006

Closed
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/fix-decidable-field-names
Closed

[Merged by Bors] - fix: correct names of LinearOrder decidable fields#4006
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/fix-decidable-field-names

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented May 15, 2023

This renames

  • decidable_eq to decidableEq
  • decidable_lt to decidableLT
  • decidable_le to decidableLE
  • decidableLT_of_decidableLE to decidableLTOfDecidableLE
  • decidableEq_of_decidableLE to decidableEqOfDecidableLE

These fields are data not proofs, so they should be lowerCamelCased.


Open in Gitpod

This renames
* `decidable_eq` to `deciableEq`
* `decidable_lt` to `deciableLT`
* `decidable_le` to `deciableLE`
* `decidableLT_of_decidableLE` to `decidableLTOfDecidableLE`
* `decidableEq_of_decidableLE` to `decidableEqOfDecidableLE`
@eric-wieser eric-wieser added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels May 15, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 15, 2023

bors d+

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 15, 2023
@bors
Copy link
Copy Markdown

bors bot commented May 15, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

(cache is uploaded, so in the unlikely event that the linter fails it should do so quickly)

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 15, 2023
bors bot pushed a commit that referenced this pull request May 15, 2023
This renames
* `decidable_eq` to `decidableEq`
* `decidable_lt` to `decidableLT`
* `decidable_le` to `decidableLE`
* `decidableLT_of_decidableLE` to `decidableLTOfDecidableLE`
* `decidableEq_of_decidableLE` to `decidableEqOfDecidableLE`

These fields are data not proofs, so they should be `lowerCamelCased`.
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label May 15, 2023
@bors
Copy link
Copy Markdown

bors bot commented May 15, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: correct names of LinearOrder decidable fields [Merged by Bors] - fix: correct names of LinearOrder decidable fields May 15, 2023
@bors bors bot closed this May 15, 2023
@bors bors bot deleted the eric-wieser/fix-decidable-field-names branch May 15, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants