[Merged by Bors] - feat: finset distributivity lemmas#3937
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - feat: finset distributivity lemmas#3937YaelDillies wants to merge 3 commits intomasterfrom
finset distributivity lemmas#3937YaelDillies wants to merge 3 commits intomasterfrom
Conversation
Match leanprover-community/mathlib3#18611 [`data.finset.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`2d44d6823a96f9c79b7d1ab185918377be663424`](https://leanprover-community.github.io/mathlib-port-status/file/data/finset/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..2d44d6823a96f9c79b7d1ab185918377be663424)
eric-wieser
reviewed
May 13, 2023
eric-wieser
reviewed
May 13, 2023
eric-wieser
reviewed
May 13, 2023
eric-wieser
reviewed
May 13, 2023
Comment on lines
+595
to
+597
| -- porting note: `simpa` doesn't support placeholders in proof terms | ||
| have := h (fun j hj => if hji : j = i then cast (congr_arg κ hji.symm) a | ||
| else g _ <| mem_of_mem_insert_of_ne hj hji) (fun j hj => ?_) |
Member
There was a problem hiding this comment.
So ?_ doesn't work in a simpa using?
eric-wieser
approved these changes
May 13, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Some minor comments
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 14, 2023
Match leanprover-community/mathlib3#18611 [`data.finset.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`2d44d6823a96f9c79b7d1ab185918377be663424`](https://leanprover-community.github.io/mathlib-port-status/file/data/finset/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..2d44d6823a96f9c79b7d1ab185918377be663424)
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
finset distributivity lemmasfinset distributivity lemmas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match leanprover-community/mathlib3#18611
data.finset.lattice@9d684a893c52e1d6692a504a118bfccbae04feeb..2d44d6823a96f9c79b7d1ab185918377be663424