[Merged by Bors] - fix: use cleanupAnnotations in symm and trans#3768
Closed
fpvandoorn wants to merge 14 commits intomasterfrom
Closed
[Merged by Bors] - fix: use cleanupAnnotations in symm and trans#3768fpvandoorn wants to merge 14 commits intomasterfrom
fpvandoorn wants to merge 14 commits intomasterfrom
Conversation
Member
Author
|
I think @thorimur is planning to implement a better fix that might unfold some reducible definitions. This will work the same on 99% of cases that we can use in the meantime, and will only differ if relations and/or goals use reducible definitions. |
Contributor
|
Thanks! bors d+ |
|
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 17, 2023
* `trans` would fail if the goal had an annotation * `symm` would use `whnf` with normal transparency on the goal, now we use `cleanupAnnotations`. * `rfl` is fixed in #3758
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transwould fail if the goal had an annotationsymmwould usewhnfwith normal transparency on the goal, now we usecleanupAnnotations.rflis fixed in [Merged by Bors] - refactor, fix:MetaMversion ofrfltactic and missingwhnfR/instantiateMVars#3758