[Merged by Bors] - feat: smoothness on a set can be checked in extended charts#36816
Closed
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: smoothness on a set can be checked in extended charts#36816grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
Cherry-picked from leanprover-community#28796
Cherry-picked form leanprover-community#28796, and used to prove immersions are smooth.
PR summary 369423a5d4
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Geometry.Manifold.ContMDiff.Atlas | 2226 | 2229 | +3 (+0.13%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Geometry.Manifold.ContMDiff.Atlas |
3 |
Declarations diff
+ ContDiffWithinAt.fst
+ ContDiffWithinAt.snd
+ OpenPartialHomeomorph.contMDiffOn_writtenInExtend_iff
+ OpenPartialHomeomorph.contMDiffWithinAt_writtenInExtend_iff
+ contDiffAt_prod_iff
+ contDiffOn_prod_iff
+ contDiffWithinAt_prod_iff
+ contDiff_prod_iff
+ contMDiffOn_extend
+ extend_target_eq_image_source
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Thanks for the fast review! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
justus-springer
pushed a commit
to justus-springer/mathlib4
that referenced
this pull request
Mar 28, 2026
…er-community#36816) Cherry-picked from leanprover-community#28796: it might not get used in the eventual PR there, but this lemma seems useful independently. (In any case, I would like to use these lemmas now, and there is no reason to wait until I have filled in the missing API for leanprover-community#28796.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #28796: it might not get used in the eventual PR there, but this lemma seems useful independently.
(In any case, I would like to use these lemmas now, and there is no reason to wait until I have filled in the missing API for #28796.)