[Merged by Bors] - chore: golf using custom elaborators#36235
Closed
grunweg wants to merge 6 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: golf using custom elaborators#36235grunweg wants to merge 6 commits intoleanprover-community:masterfrom
grunweg wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
The final pieces from leanprover-community#30357.
grunweg
commented
Mar 5, 2026
grunweg
commented
Mar 5, 2026
grunweg
commented
Mar 5, 2026
grunweg
commented
Mar 5, 2026
PR summary d39c0a2262
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Geometry.Manifold.Complex | 2587 | 2590 | +3 (+0.12%) |
| Mathlib.Geometry.Manifold.ContMDiffMap | 2225 | 2227 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.VectorBundle.Tangent | 2233 | 2235 | +2 (+0.09%) |
| Mathlib.Geometry.Manifold.BumpFunction | 2541 | 2543 | +2 (+0.08%) |
Import changes for all files
| Files | Import difference |
|---|---|
4 filesMathlib.Geometry.Manifold.BumpFunction Mathlib.Geometry.Manifold.ContMDiffMap Mathlib.Geometry.Manifold.VectorBundle.Pullback Mathlib.Geometry.Manifold.VectorBundle.Tangent |
2 |
Mathlib.Geometry.Manifold.Complex |
3 |
Declarations diff
+-+- contMDiffAt
+-+- mdifferentiableOn
+-+-+- contMDiff
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
grunweg
commented
Mar 6, 2026
| and that local structomorphisms are `C^n` with `C^n` inverses. | ||
| -/ | ||
|
|
||
| assert_not_exists mfderiv |
Contributor
Author
There was a problem hiding this comment.
For the record: this change (and its analogue in the two other files) just adds an assert_not_exists which is already transitively implied - to make this clearer.
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Contributor
Author
|
Thanks for the review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
The final pieces from #30357.
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Mar 8, 2026
The final pieces from leanprover-community#30357.
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Mar 9, 2026
The final pieces from leanprover-community#30357.
seewoo5
pushed a commit
to seewoo5/mathlib4
that referenced
this pull request
Mar 9, 2026
The final pieces from leanprover-community#30357.
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Mar 10, 2026
The final pieces from leanprover-community#30357.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final pieces from #30357.
I'm happy to split these changes further if you prefer.