Skip to content

[Merged by Bors] - fix(Data/Rel): change what image_eq_cod_of_dom_subset states#35696

Closed
GrigorenkoPV wants to merge 1 commit intoleanprover-community:masterfrom
GrigorenkoPV:image_eq_cod_of_dom_subset
Closed

[Merged by Bors] - fix(Data/Rel): change what image_eq_cod_of_dom_subset states#35696
GrigorenkoPV wants to merge 1 commit intoleanprover-community:masterfrom
GrigorenkoPV:image_eq_cod_of_dom_subset

Conversation

@GrigorenkoPV
Copy link
Copy Markdown
Contributor

It used to be identical to its neighbor, preimage_eq_dom_of_cod_subset.
Both lemmas seem to have been introduced in #25587.


I think this is technically a breaking change? Not sure what has to be done here.

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 23, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

PR summary 02e8b79177

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Feb 23, 2026
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. It's a breaking change, but a minor one (and I imagine if someone else were using this lemma, they would have already noticed this!)

Copy link
Copy Markdown
Contributor

@joneugster joneugster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this mistake!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

🚀 Pull request has been placed on the maintainer queue by joneugster.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 6, 2026
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Mar 10, 2026

Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 10, 2026
It used to be identical to its neighbor, `preimage_eq_dom_of_cod_subset`.
Both lemmas seem to have been introduced in #25587.

Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 10, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 10, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Data/Rel): change what image_eq_cod_of_dom_subset states [Merged by Bors] - fix(Data/Rel): change what image_eq_cod_of_dom_subset states Mar 10, 2026
@mathlib-bors mathlib-bors bot closed this Mar 10, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
…rover-community#35696)

It used to be identical to its neighbor, `preimage_eq_dom_of_cod_subset`.
Both lemmas seem to have been introduced in leanprover-community#25587.

Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
@GrigorenkoPV GrigorenkoPV deleted the image_eq_cod_of_dom_subset branch March 12, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants