Skip to content

[Merged by Bors] - feat: ab < ac and b ≤ c implies 0 < a#35302

Closed
CoolRmal wants to merge 1 commit intoleanprover-community:masterfrom
CoolRmal:posmulrightlt
Closed

[Merged by Bors] - feat: ab < ac and b ≤ c implies 0 < a#35302
CoolRmal wants to merge 1 commit intoleanprover-community:masterfrom
CoolRmal:posmulrightlt

Conversation

@CoolRmal
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

PR summary fd6add7853

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ pos_of_left_mul_lt_le
+ pos_of_right_mul_lt_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment on lines +730 to +732
by_cases! ha : 0 < a
· exact ha
· grind [mul_le_mul_of_nonpos_left hbc ha]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? Same below.

Suggested change
by_cases! ha : 0 < a
· exact ha
· grind [mul_le_mul_of_nonpos_left hbc ha]
by_contra! ha
grind [mul_le_mul_of_nonpos_left hbc ha]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this does not work. I guess it is because ha has two different meanings in these two subgoals.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why does it not work? I would have expected that that to work as well

Copy link
Copy Markdown
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 15, 2026

Pull request successfully merged into master.

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants