Skip to content

[Merged by Bors] - chore: port lint-style.py from mathlib#352

Closed
kim-em wants to merge 13 commits intomasterfrom
lint-style
Closed

[Merged by Bors] - chore: port lint-style.py from mathlib#352
kim-em wants to merge 13 commits intomasterfrom
lint-style

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jul 26, 2022

Some of these are no longer relevant, but I want to see what works before cleaning up.

@kim-em kim-em marked this pull request as ready for review July 26, 2022 23:45
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jul 27, 2022

This runs, and respects the content of scripts/style-extensions.txt.

I propose that actually fixing style exceptions, and removing the style tests which are not relevant for mathlib4 (e.g. I think the curly brace linter), happens in a subsequent PR.

@digama0 digama0 requested a review from gebner July 27, 2022 00:42
@gebner
Copy link
Copy Markdown
Member

gebner commented Aug 18, 2022

Obviously this should eventually be rewritten in Lean, but we can use the python script for now.

Before merging, we should remove the curly braces linter though because it has lots of false positives.

@gebner gebner added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Aug 18, 2022
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Sep 13, 2022

I've removed the curly brace linter, the indentation linter and the unfreeze_local_instance linter, as they are not fit for purpose for Lean4. I've also added a TODO about re-implementing in Lean4!

@kim-em kim-em added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Sep 13, 2022
@gebner
Copy link
Copy Markdown
Member

gebner commented Sep 15, 2022

Great, all exceptions look legit now!

bors merge

bors bot pushed a commit that referenced this pull request Sep 15, 2022
Some of these are no longer relevant, but I want to see what works before cleaning up.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Sep 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: port lint-style.py from mathlib [Merged by Bors] - chore: port lint-style.py from mathlib Sep 15, 2022
@bors bors bot closed this Sep 15, 2022
@bors bors bot deleted the lint-style branch September 15, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants