[Merged by Bors] - fix: check for a space of continuous linear maps over not-the-identity#35176
Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - fix: check for a space of continuous linear maps over not-the-identity#35176grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
Improves an error message, and fixes a TODO in the code.
2 tasks
PR summary 4aa0616ac5Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
joneugster
approved these changes
Feb 18, 2026
Contributor
joneugster
left a comment
There was a problem hiding this comment.
LGTM, thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
3 tasks
- mark as private, as we only use it twice - tweak the doc-string slightly - make it error when the check fails: this is the only behaviour its two call-sites require, and simplifies the return type slightly - reduce indentation a bit
Contributor
Author
|
@thorimur Would you like to double-check that I did justice to your change? (I just added the pureIsDefEq change, which I had missed. I see that another difference was you checking |
thorimur
reviewed
Feb 18, 2026
Contributor
|
Looks good to me! :) I'd maintainer merge if it weren't already on the queue. :) |
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
Vierkantor
approved these changes
Feb 19, 2026
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! 🎉
bors r+
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
#35176) Improves an error message, and fixes a TODO in the code. Along the way, tweak `isCLMReduciblyDefEqCoeffients` a bit - make it private (as it is only used twice, and its return value is a bit complicated for public API), - make it return an error directly if not successful: this matches what its two callers do, - tweak the doc-string slightly and reduce right-ward drift a bit Co-authored-by: thorimur <thomasmurrills@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Mar 2, 2026
leanprover-community#35176) Improves an error message, and fixes a TODO in the code. Along the way, tweak `isCLMReduciblyDefEqCoeffients` a bit - make it private (as it is only used twice, and its return value is a bit complicated for public API), - make it return an error directly if not successful: this matches what its two callers do, - tweak the doc-string slightly and reduce right-ward drift a bit Co-authored-by: thorimur <thomasmurrills@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves an error message, and fixes a TODO in the code.
Along the way, tweak
isCLMReduciblyDefEqCoeffientsa bitCo-authored-by: thorimur thomasmurrills@gmail.com