Skip to content

[Merged by Bors] - feat: port Topology.Algebra.ValuedField#3511

Closed
ymonbru wants to merge 14 commits intomasterfrom
port/Topology.Algebra.ValuedField
Closed

[Merged by Bors] - feat: port Topology.Algebra.ValuedField#3511
ymonbru wants to merge 14 commits intomasterfrom
port/Topology.Algebra.ValuedField

Conversation

@ymonbru
Copy link
Copy Markdown
Contributor

@ymonbru ymonbru commented Apr 18, 2023


Open in Gitpod

ymonbru added 3 commits April 18, 2023 21:41
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@ymonbru ymonbru added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 18, 2023
@ymonbru
Copy link
Copy Markdown
Contributor Author

ymonbru commented Apr 19, 2023

I think that i spoted all the syntax errors.
For the remaining, lean is complaining about conversion or being unable to conclude the proof

@ymonbru ymonbru added the help-wanted The author needs attention to resolve issues label Apr 19, 2023
bors bot pushed a commit that referenced this pull request Apr 20, 2023
mac users should have this in their `.gitignore` file, but sometimes don't, as evidenced by #3511, which then unfortunately broke the port-status bot for a day!



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kbuzzard pushed a commit that referenced this pull request Apr 22, 2023
mac users should have this in their `.gitignore` file, but sometimes don't, as evidenced by #3511, which then unfortunately broke the port-status bot for a day!



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@int-y1
Copy link
Copy Markdown
Contributor

int-y1 commented Apr 23, 2023

todo:

  • valuedCompletion_apply has a norm_cast error

@int-y1 int-y1 removed the WIP Work in progress label Apr 23, 2023
@int-y1 int-y1 changed the title feat: port Topology.Algebra.Valued.Field feat: port Topology.Algebra.ValuedField Apr 23, 2023
kim-em added a commit that referenced this pull request May 10, 2023
mac users should have this in their `.gitignore` file, but sometimes don't, as evidenced by #3511, which then unfortunately broke the port-status bot for a day!



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@jjaassoonn
Copy link
Copy Markdown
Collaborator

todo:

  • valuedCompletion_apply has a norm_cast error

I pushed a commit where this norm_cast is removed (Γ₀ can't be coerced into another type). The same treatment is done at DistribMulActionHom.coe_toLinearMap in Algebra.Module.LinearMap.lean.

@jjaassoonn jjaassoonn added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed help-wanted The author needs attention to resolve issues labels Jun 1, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 1, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 1, 2023
bors bot pushed a commit that referenced this pull request Jun 1, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
@bors
Copy link
Copy Markdown

bors bot commented Jun 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.Algebra.ValuedField [Merged by Bors] - feat: port Topology.Algebra.ValuedField Jun 1, 2023
@bors bors bot closed this Jun 1, 2023
@bors bors bot deleted the port/Topology.Algebra.ValuedField branch June 1, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants