Skip to content

[Merged by Bors] - fix(CI): autolabel does not add labels for gaps in autolabels#34568

Closed
adomani wants to merge 1 commit intoleanprover-community:masterfrom
adomani:autolabel_ignores_gaps_in_labels
Closed

[Merged by Bors] - fix(CI): autolabel does not add labels for gaps in autolabels#34568
adomani wants to merge 1 commit intoleanprover-community:masterfrom
adomani:autolabel_ignores_gaps_in_labels

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Jan 29, 2026

The script now checks for labels only the lines starting with ::notice::. This avoid matching the ::warning:: lines, which highlight gaps in the directory coverage of lake exe autolabel.

#mathlib4 > Mathlib/* labels @ 💬


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary aa0d62f5cb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adomani adomani added the CI Modifies the continuous integration setup or other automation label Jan 29, 2026
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Jan 29, 2026

Notice that I added the label manually, since the autolabelling script used the master version (action), which incorrectly identifies Mathlib/Geometry/Polygon and CI as potential labels.

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 29, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 29, 2026
The script now checks for labels only the lines starting with `::notice::`.  This avoid matching the `::warning::` lines, which highlight gaps in the directory coverage of `lake exe autolabel`.

[#mathlib4 > Mathlib/&#42; labels @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.2F*.20labels/near/569988520)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 29, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(CI): autolabel does not add labels for gaps in autolabels [Merged by Bors] - fix(CI): autolabel does not add labels for gaps in autolabels Jan 29, 2026
@mathlib-bors mathlib-bors bot closed this Jan 29, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Feb 3, 2026
…over-community#34568)

The script now checks for labels only the lines starting with `::notice::`.  This avoid matching the `::warning::` lines, which highlight gaps in the directory coverage of `lake exe autolabel`.

[#mathlib4 > Mathlib/&leanprover-community#42; labels @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.2F*.20labels/near/569988520)
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Feb 15, 2026
…over-community#34568)

The script now checks for labels only the lines starting with `::notice::`.  This avoid matching the `::warning::` lines, which highlight gaps in the directory coverage of `lake exe autolabel`.

[#mathlib4 > Mathlib/&leanprover-community#42; labels @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.2F*.20labels/near/569988520)
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
…over-community#34568)

The script now checks for labels only the lines starting with `::notice::`.  This avoid matching the `::warning::` lines, which highlight gaps in the directory coverage of `lake exe autolabel`.

[#mathlib4 > Mathlib/&leanprover-community#42; labels @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.2F*.20labels/near/569988520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants