Skip to content

[Merged by Bors] - chore: fix and re-enable differential geometry elaborators test#34562

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:elaborator-errors
Closed

[Merged by Bors] - chore: fix and re-enable differential geometry elaborators test#34562
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:elaborator-errors

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 29, 2026

set_option pp.mvars false normalises the universe levels, making the output sufficiently deterministic.
Follow-up to #30744.


Open in Gitpod

set_option pp.mvars false normalises the universe levels, making the output
sufficiently deterministic. Follow-up to leanprover-community#30744.
@grunweg grunweg requested a review from Vierkantor January 29, 2026 09:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

PR summary 087469e249

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands labels Jan 29, 2026
Copy link
Copy Markdown
Contributor

@joneugster joneugster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@joneugster joneugster removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 30, 2026
@joneugster joneugster self-assigned this Jan 30, 2026
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by joneugster.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 30, 2026
@adomani
Copy link
Copy Markdown
Contributor

adomani commented Jan 30, 2026

Let's try this and see how it works, thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 30, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2026
`set_option pp.mvars false` normalises the universe levels, making the output sufficiently deterministic.
Follow-up to #30744.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 30, 2026

Canceled.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 30, 2026

Sorry, I wanted to make one last tweak (and forgot to push until now).
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2026
`set_option pp.mvars false` normalises the universe levels, making the output sufficiently deterministic.
Follow-up to #30744.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 30, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix and re-enable differential geometry elaborators test [Merged by Bors] - chore: fix and re-enable differential geometry elaborators test Jan 30, 2026
@mathlib-bors mathlib-bors bot closed this Jan 30, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Feb 3, 2026
…prover-community#34562)

`set_option pp.mvars false` normalises the universe levels, making the output sufficiently deterministic.
Follow-up to leanprover-community#30744.
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Feb 15, 2026
…prover-community#34562)

`set_option pp.mvars false` normalises the universe levels, making the output sufficiently deterministic.
Follow-up to leanprover-community#30744.
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
…prover-community#34562)

`set_option pp.mvars false` normalises the universe levels, making the output sufficiently deterministic.
Follow-up to leanprover-community#30744.
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
…prover-community#34562)

`set_option pp.mvars false` normalises the universe levels, making the output sufficiently deterministic.
Follow-up to leanprover-community#30744.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants