[Merged by Bors] - feat: mfderiv_smul#34263
Closed
grunweg wants to merge 11 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: mfderiv_smul#34263grunweg wants to merge 11 commits intoleanprover-community:masterfrom
grunweg wants to merge 11 commits intoleanprover-community:masterfrom
Conversation
PR summary 2050510330Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 10109 | 1 | backward.isDefEq |
Current commit 9c0a58ae22
Reference commit 2050510330
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
|
This pull request has conflicts, please merge |
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Mar 6, 2026
This was referenced Mar 7, 2026
ADedecker
reviewed
Mar 8, 2026
jcommelin
reviewed
Mar 10, 2026
Member
jcommelin
left a comment
There was a problem hiding this comment.
bors d+
Does @PatrickMassot want this email adress, or his uni one, in the co-authored line?
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Thanks for the review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Some invisible mathematics is showing up when working with scalar multiplication by a function: a priori, the `mfderiv` yields an element in a suitable tangent space --- which we identity implicitly with the corresponding vector/scalar. We insert the canonical identification `NormedSpace.fromTangentSpace` as needed to deal with this. From the path towards geodesics and the Levi-Civita connection. Co-authored-by: Patrick Massot [patrickmassot@free.fr](mailto:patrickmassot@free.fr) Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some invisible mathematics is showing up when working with scalar multiplication by a function: a priori, the
mfderivyields an element in a suitable tangent space --- which we identify implicitly with the corresponding vector/scalar. We insert the canonical identificationNormedSpace.fromTangentSpaceas needed to deal with this.From the path towards geodesics and the Levi-Civita connection.
Co-authored-by: Patrick Massot patrickmassot@free.fr
Note: the 10-line snippet defining
NormedSpace.fromTangentSpaceappears both here and in #36279; it can be reviewed in whichever PR is handled first, then the other PR rebased on master.