Skip to content

[Merged by Bors] - feat: port Data.Seq.WSeq#3405

Closed
Komyyy wants to merge 12 commits intomasterfrom
port/Data.Seq.WSeq
Closed

[Merged by Bors] - feat: port Data.Seq.WSeq#3405
Komyyy wants to merge 12 commits intomasterfrom
port/Data.Seq.WSeq

Conversation

@Komyyy
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy commented Apr 12, 2023

This PR also make Option.recOn computable.


Open in Gitpod

@Komyyy Komyyy added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 12, 2023
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 12, 2023
@Komyyy Komyyy added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. help-wanted The author needs attention to resolve issues WIP Work in progress awaiting-review and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. help-wanted The author needs attention to resolve issues labels Apr 14, 2023
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Apr 15, 2023
@eric-wieser
Copy link
Copy Markdown
Member

Please run git rebase -i origin/master, remove the commits that are not part of this port, then git push origin --force-with-lease

@Parcly-Taxel Parcly-Taxel added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 15, 2023
Komyyy and others added 3 commits April 20, 2023 13:25
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: Scott Morrison <scott@tqft.net>
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Apr 20, 2023

@Komyyy, I pushed a change that removes (pending CI!!) the simpNF attribute. If this looks okay and CI passes, could you merge. Otherwise please mark this back as awaiting-review.

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Apr 20, 2023

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Apr 20, 2023
@Komyyy
Copy link
Copy Markdown
Contributor Author

Komyyy commented Apr 20, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 20, 2023
This PR also make `Option.recOn` computable.



Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Apr 20, 2023

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Apr 20, 2023
This PR also make `Option.recOn` computable.



Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Apr 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Seq.WSeq [Merged by Bors] - feat: port Data.Seq.WSeq Apr 20, 2023
@bors bors bot closed this Apr 20, 2023
@bors bors bot deleted the port/Data.Seq.WSeq branch April 20, 2023 08:28
kbuzzard pushed a commit that referenced this pull request Apr 22, 2023
This PR also make `Option.recOn` computable.



Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em added a commit that referenced this pull request May 10, 2023
This PR also make `Option.recOn` computable.



Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). mathlib-port This is a port of a theory file from mathlib.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants