[Merged by Bors] - fix: example of GL(V) being a Lie group#33923
Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - fix: example of GL(V) being a Lie group#33923grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.
PR summary b2f24e70b3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
3 tasks
ocfnash
reviewed
Jan 14, 2026
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
grunweg
commented
Jan 14, 2026
grunweg
commented
Jan 14, 2026
Contributor
Author
|
I have switched to using a parameter |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.
Contributor
|
Build failed: |
Contributor
|
bors r+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
eliasjudin
pushed a commit
to eliasjudin/mathlib4
that referenced
this pull request
Jan 18, 2026
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.
bilichboris
pushed a commit
to bilichboris/mathlib4
that referenced
this pull request
Jan 18, 2026
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc-string was missing a smoothness parameter. Fix this, and copy-paste this example into the file to ensure it does not regress in the future.