[Merged by Bors] - chore: have linarith print the goal when it fails#3273
Closed
[Merged by Bors] - chore: have linarith print the goal when it fails#3273
Conversation
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
This makes `linarith` print the goal (including hypotheses) when it fails, as many other tactics do. This was motivated by watching the `sagredo` tactic trying to use `linarith`, but failing to see that it didn't quite have the correct hypotheses yet. Once it gave up on using `linarith`, it tried `contradiction`, which printed a more helpful error message (in which a human, although not quite GPT, could easily see the inequalities weren't quite right). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Apr 22, 2023
This makes `linarith` print the goal (including hypotheses) when it fails, as many other tactics do. This was motivated by watching the `sagredo` tactic trying to use `linarith`, but failing to see that it didn't quite have the correct hypotheses yet. Once it gave up on using `linarith`, it tried `contradiction`, which printed a more helpful error message (in which a human, although not quite GPT, could easily see the inequalities weren't quite right). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em
added a commit
that referenced
this pull request
May 10, 2023
This makes `linarith` print the goal (including hypotheses) when it fails, as many other tactics do. This was motivated by watching the `sagredo` tactic trying to use `linarith`, but failing to see that it didn't quite have the correct hypotheses yet. Once it gave up on using `linarith`, it tried `contradiction`, which printed a more helpful error message (in which a human, although not quite GPT, could easily see the inequalities weren't quite right). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
linarithprint the goal (including hypotheses) when it fails, as many other tactics do.This was motivated by watching the
sagredotactic trying to uselinarith, but failing to see that it didn't quite have the correct hypotheses yet. Once it gave up on usinglinarith, it triedcontradiction, which printed a more helpful error message (in which a human, although not quite GPT, could easily see the inequalities weren't quite right).