Skip to content

[Merged by Bors] - feat(LinearAlgebra/Multilinear): constructing MultilinearMap over DirectSum#32450

Closed
morrison-daniel wants to merge 94 commits intoleanprover-community:masterfrom
morrison-daniel:multilinear-from
Closed

[Merged by Bors] - feat(LinearAlgebra/Multilinear): constructing MultilinearMap over DirectSum#32450
morrison-daniel wants to merge 94 commits intoleanprover-community:masterfrom
morrison-daniel:multilinear-from

Conversation

@morrison-daniel
Copy link
Copy Markdown
Collaborator

@morrison-daniel morrison-daniel commented Dec 5, 2025

Adds fromDirectSumEquiv as an analog for fromDFinsuppEquiv specifically for DirectSum. This map combines a collection of MultilinearMaps into a single MultilinearMap on the DirectSum.


Open in Gitpod

morel and others added 30 commits March 4, 2024 17:45
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…community/mathlib4 into SM.PiTensorProduct.DirectSum
…community/mathlib4 into SM.PiTensorProduct.DirectSum
Co-authored-by: Eric Wieser <efw@google.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Dec 5, 2025
@morrison-daniel morrison-daniel added the WIP Work in progress label Dec 5, 2025
@morrison-daniel morrison-daniel marked this pull request as draft December 5, 2025 02:42
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 5, 2025

PR summary ae8e527219

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.LinearAlgebra.Multilinear.DirectSum (new file) 771

Declarations diff

+ directSum_ext
+ fromDirectSumEquiv
+ fromDirectSumEquiv_apply
+ fromDirectSumEquiv_lof
+ fromDirectSumEquiv_symm_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@morrison-daniel morrison-daniel changed the title feat(LinearAlgebra/Multilinear): interactions of DirectSum and Pi with MultilinearMap feat(LinearAlgebra/Multilinear): constructing MultilinearMap over DirectSum Dec 5, 2025
@morrison-daniel morrison-daniel marked this pull request as ready for review December 5, 2025 04:11
@morrison-daniel morrison-daniel removed the WIP Work in progress label Dec 5, 2025
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's great to see this material start to move at last.

One final remark about my inline comments is that I have used (i : ι) → κ i rather than Π i, κ i since there was a mixture of notation in the file. Either is fine (though the former is what the delaborator uses so you'll see that in the infoview).

Please apply the suggestions and then feel free to merge!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 5, 2025

✌️ morrison-daniel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 5, 2025
morrison-daniel and others added 2 commits December 5, 2025 10:57
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@morrison-daniel
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 5, 2025
…DirectSum` (#32450)

Adds `fromDirectSumEquiv` as an analog for `fromDFinsuppEquiv` specifically for `DirectSum`. This map combines a collection of `MultilinearMap`s into a single `MultilinearMap` on the `DirectSum`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra/Multilinear): constructing MultilinearMap over DirectSum [Merged by Bors] - feat(LinearAlgebra/Multilinear): constructing MultilinearMap over DirectSum Dec 5, 2025
@mathlib-bors mathlib-bors bot closed this Dec 5, 2025
@morrison-daniel morrison-daniel deleted the multilinear-from branch December 5, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants