[Merged by Bors] - feat: port Data.Matrix.PEquiv#3234
Closed
Ruben-VandeVelde wants to merge 13 commits intomasterfrom
Closed
[Merged by Bors] - feat: port Data.Matrix.PEquiv#3234Ruben-VandeVelde wants to merge 13 commits intomasterfrom
Ruben-VandeVelde wants to merge 13 commits intomasterfrom
Conversation
Contributor
Ruben-VandeVelde
commented
Apr 2, 2023
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
kim-em
reviewed
Apr 2, 2023
eric-wieser
reviewed
Apr 3, 2023
Mathlib/Data/Matrix/PEquiv.lean
Outdated
Comment on lines
+54
to
+56
| instance [DecidableEq n] (j : n) (o : Option n) : Decidable (j ∈ o) := by | ||
| rw [←Option.mem_toList] | ||
| infer_instance |
Member
There was a problem hiding this comment.
This instance shouldn't need [DecidableEq n]
What instance is found in Lean3?
Contributor
Author
There was a problem hiding this comment.
option.decidable_eq
eric-wieser
reviewed
Apr 3, 2023
eric-wieser
reviewed
Apr 3, 2023
Mathlib/Data/Matrix/PEquiv.lean
Outdated
Comment on lines
+53
to
+56
| -- Porting note: added | ||
| local instance [DecidableEq n] (j : n) (o : Option n) : Decidable (j ∈ o) := | ||
| haveI : Decidable (o = some j) := inferInstance | ||
| this |
Member
There was a problem hiding this comment.
This is definitely better, but belongs in the same file that defines the ∈ notation
Contributor
Author
There was a problem hiding this comment.
That's Std.Data.Option.Basic. I'll submit a PR there tomorrow, but wouldn't mind if we moved this along in the meantime.
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.