Skip to content

[Merged by Bors] - feat: port Logic.Equiv.TransferInstance#3206

Closed
Parcly-Taxel wants to merge 14 commits intomasterfrom
port/Logic.Equiv.TransferInstance
Closed

[Merged by Bors] - feat: port Logic.Equiv.TransferInstance#3206
Parcly-Taxel wants to merge 14 commits intomasterfrom
port/Logic.Equiv.TransferInstance

Conversation

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel Parcly-Taxel added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 31, 2023
@joelriou
Copy link
Copy Markdown
Contributor

I have succeeded in having the file compile by slightly changing the formulation of lemmas like mul_def:

@[to_additive]
theorem mul_def [Mul β] (x y : α) :
  letI := Equiv.Mul e
  x * y = e.symm (e x * e y) := rfl
-- instead of
--theorem mul_def [Mul β] (x y : α) : @Mul.mul _ (Equiv.Mul e) x y = e.symm (e x * e y) :=
--  rfl

Doing so makes simp only [mul_def] work (I cannot completely explain why though...). Then, I was able to make the whole file compile. However, I believe that all the lemmas _def in this file should be modified accordingly before this is merged.

@Parcly-Taxel Parcly-Taxel added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Apr 18, 2023
@eric-wieser
Copy link
Copy Markdown
Member

(I cannot completely explain why though...

The new spelling uses HMul, which is what * is notation for. That is why it now works.

@eric-wieser
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 19, 2023
bors bot pushed a commit that referenced this pull request Apr 19, 2023
Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Apr 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Logic.Equiv.TransferInstance [Merged by Bors] - feat: port Logic.Equiv.TransferInstance Apr 19, 2023
@bors bors bot closed this Apr 19, 2023
@bors bors bot deleted the port/Logic.Equiv.TransferInstance branch April 19, 2023 09:23
kim-em pushed a commit that referenced this pull request May 10, 2023
Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants