[Merged by Bors] - feat: port Logic.Equiv.TransferInstance#3206
Closed
Parcly-Taxel wants to merge 14 commits intomasterfrom
Closed
[Merged by Bors] - feat: port Logic.Equiv.TransferInstance#3206Parcly-Taxel wants to merge 14 commits intomasterfrom
Parcly-Taxel wants to merge 14 commits intomasterfrom
Conversation
Collaborator
Parcly-Taxel
commented
Mar 31, 2023
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
eric-wieser
reviewed
Mar 31, 2023
Contributor
|
I have succeeded in having the file compile by slightly changing the formulation of lemmas like @[to_additive]
theorem mul_def [Mul β] (x y : α) :
letI := Equiv.Mul e
x * y = e.symm (e x * e y) := rfl
-- instead of
--theorem mul_def [Mul β] (x y : α) : @Mul.mul _ (Equiv.Mul e) x y = e.symm (e x * e y) :=
-- rflDoing so makes |
1 task
Member
The new spelling uses |
This was referenced Apr 19, 2023
eric-wieser
approved these changes
Apr 19, 2023
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
kim-em
pushed a commit
that referenced
this pull request
May 10, 2023
Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.