Skip to content

[Merged by Bors] - feat: ContinuousLinearEquiv.submoduleMap and friends#31899

Closed
grunweg wants to merge 9 commits intoleanprover-community:masterfrom
grunweg:cle-submodulemap
Closed

[Merged by Bors] - feat: ContinuousLinearEquiv.submoduleMap and friends#31899
grunweg wants to merge 9 commits intoleanprover-community:masterfrom
grunweg:cle-submodulemap

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Nov 21, 2025 •
edited
Loading

The continuous analogue of LinearEquiv.{submoduleMap, submoduleMap', ofSubmodules}.
Also add ContinuousLinearMap.ofEq and Homeomorph.ofEqSubtypes, as these are necessary for the proof.

This will be used in #28793 for dealing with a universe-polymorphic definition for smooth immersions.

Open in Gitpod

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Nov 21, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 21, 2025 •
edited
Loading

PR summary 21bf164c77

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Homeomorph.ofEqSubtypes
+ Homeomorph.ofEqSubtypes_toEquiv
+ ofEq
+ ofSubmodule'
+ ofSubmodule'_apply
+ ofSubmodule'_symm_apply
+ ofSubmodule'_toContinuousLinearMap
+ ofSubmodules
+ ofSubmodules_apply
+ ofSubmodules_symm_apply
+ submoduleMap
+ submoduleMap_apply
+ submoduleMap_symm_apply

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg changed the title feat: ContinuousLinearEquiv.submoduleMap feat: ContinuousLinearEquiv.submoduleMap and friends Nov 21, 2025
@grunweg grunweg added t-algebra Algebra (groups, rings, fields, etc) and removed t-topology Topological spaces, uniform spaces, metric spaces, filters labels Nov 21, 2025
@grunweg grunweg mentioned this pull request Nov 21, 2025
Closed
5 tasks
sgouezel
sgouezel reviewed Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 21, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 21, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 21, 2025 •
edited
Loading

Thank you for the really quick review!
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 21, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 21, 2025
@grunweg
feat: ContinuousLinearEquiv.submoduleMap and friends (#31899)
4c34f6c 
The continuous analogue of `LinearEquiv.{submoduleMap, submoduleMap', ofSubmodules}`.
Also add `ContinuousLinearMap.ofEq` and `Homeomorph.ofEqSubtypes`, as these are necessary for the proof.

This will be used in #28793 for dealing with a universe-polymorphic definition for smooth immersions.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: ContinuousLinearEquiv.submoduleMap and friends [Merged by Bors] - feat: ContinuousLinearEquiv.submoduleMap and friends Nov 21, 2025
@mathlib-bors mathlib-bors bot closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @sgouezel