Skip to content

[Merged by Bors] - feat: Shrink instances for NormedSpace and ContinuousLinearEquiv#31897

Closed
grunweg wants to merge 23 commits intoleanprover-community:masterfrom
grunweg:shrinknorm
Closed

[Merged by Bors] - feat: Shrink instances for NormedSpace and ContinuousLinearEquiv#31897
grunweg wants to merge 23 commits intoleanprover-community:masterfrom
grunweg:shrinknorm

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Nov 21, 2025 •
edited
Loading

These are analogous to existing instances (and places in a new file to avoid import increases).
They will be used in #28793 to make the definition of immersions universe-polymorphic.

Open in Gitpod

@grunweg
feat: transfer normed spaces and continuous linear equiv's across equ…
f32d346 
…ivalences

Analogous to existing instances for e.g. linear equivalences.
This is required for adding Shrink instances for these, which in turns are
necessary for making the definition of immersions in leanprover-community#28793
universe-polymorphic.
@grunweg
Fix CI; better documentation
dcae2af
@grunweg
Make public
103d944
@grunweg
Tweak and improve previous PR:
dc5cd50 
fix variable explicitness, generalise to semirings and fix variable order
@grunweg grunweg mentioned this pull request Nov 21, 2025
Closed
5 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 21, 2025 •
edited
Loading

PR summary 90622c868f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Shrink.continuousLinearEquiv
+ homeomorph
+ instance [NormedAddCommGroup α] : NormedAddCommGroup (Shrink.{v} α)
+ instance [SeminormedAddCommGroup α] : SeminormedAddCommGroup (Shrink.{v} α)
+ instance [SeminormedAddCommGroup α] [NormedSpace 𝕜 α] : NormedSpace 𝕜 (Shrink.{v} α)
+ topologicalSpace
- _root_.Equiv.topologicalSpace

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 21, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 22, 2025

CI errors because there are now two instances lifting a TopologicalSpace structure: one is in Topology/Instances/Shrink, the other is added in this PR. Trying to use the existing instance errors, though --- how would I figure out the correct way to solve this?

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 22, 2025

I could fix this diamond, but one existing proof breaks (and I'm a bit at a loss how to fix it).

grunweg
grunweg commented Nov 23, 2025
View reviewed changes
@grunweg grunweg mentioned this pull request Nov 24, 2025
Closed
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 24, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Nov 24, 2025

This PR/issue depends on:

sgouezel
sgouezel reviewed Nov 25, 2025
View reviewed changes
@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 25, 2025
grunweg and others added 2 commits November 25, 2025 10:13
@grunweg @sgouezel
Apply suggestions from code review
d8a1a7f 
Co-authored-by: Sebastien Gouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Move again
1997aeb
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 25, 2025

Thanks for the quick review. I have addressed all comments.
-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 25, 2025
sgouezel
sgouezel reviewed Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 25, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 25, 2025
@grunweg @sgouezel
Update Mathlib/Topology/Algebra/Module/TransferInstance.lean
21e9d33 
Co-authored-by: Sebastien Gouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 25, 2025

Thanks again!
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 25, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 25, 2025
@grunweg @chrisflav
feat: Shrink instances for NormedSpace and ContinuousLinearEquiv (#…
ff5ab5e 
…31897)

These are analogous to existing instances (and places in a new file to avoid import increases).
They will be used in #28793 to make the definition of immersions universe-polymorphic.

Co-authored-by: Christian Merten <christian@merten.dev>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 25, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Shrink instances for NormedSpace and ContinuousLinearEquiv [Merged by Bors] - feat: Shrink instances for NormedSpace and ContinuousLinearEquiv Nov 25, 2025
@mathlib-bors mathlib-bors bot closed this Nov 25, 2025
@grunweg grunweg deleted the shrinknorm branch November 25, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grunweg @mathlib4-dependent-issues-bot @sgouezel @chrisflav