Skip to content

[Merged by Bors] - feat: add contMDiffOn_empty and friends#31542

Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:mdiff-empty
Closed

[Merged by Bors] - feat: add contMDiffOn_empty and friends#31542
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:mdiff-empty

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Nov 12, 2025

On the empty set, the statement is vacuously true: this lemma is used in #30083 to eliminate some superfluous non-emptiness hypotheses.

Open in Gitpod

@grunweg
feat: add contMDiffOn_empty and friends
3af75c8 
On the empty set, the statement is vacuously true: this lemma is used in leanprover-community#30083
to eliminate some superfluous non-emptiness hypotheses.
@grunweg grunweg requested a review from ocfnash November 12, 2025 10:59
@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. t-differential-geometry Manifolds etc labels Nov 12, 2025
@grunweg grunweg mentioned this pull request Nov 12, 2025
Closed
4 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2025

PR summary 2dcdfaa5f8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ contDiffOn_empty
+ contMDiffOn_empty
+ mdifferentiableOn_empty

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Nov 12, 2025

Why only fun_prop for the first lemma?

In any case, thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 12, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 12, 2025

... because MDifferentiable(At,WithinAt,On) and ContMDiff(At,WithinAt,On) are not tagged with fun_prop.
(The reason is that inferring the model with corners is not something fun_prop can do: see e.g. this discussion #mathlib4 > Painful `ContMDiff` proof @ 💬.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 12, 2025

We have a way of mostly guessing the model with corners now, though --- so let me revisit that thread. I wanted to do so anyway for a few weeks now.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 12, 2025

Thanks for the quick review!
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 12, 2025
@grunweg
feat: add contMDiffOn_empty and friends (#31542)
ae4938d 
On the empty set, the statement is vacuously true: this lemma is used in #30083 to eliminate some superfluous non-emptiness hypotheses.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add contMDiffOn_empty and friends [Merged by Bors] - feat: add contMDiffOn_empty and friends Nov 12, 2025
@mathlib-bors mathlib-bors bot closed this Nov 12, 2025
@grunweg grunweg deleted the mdiff-empty branch November 12, 2025 12:43
thorimur pushed a commit to thorimur/mathlib4 that referenced this pull request Nov 16, 2025
@grunweg @thorimur
feat: add contMDiffOn_empty and friends (leanprover-community#31542)
537969e 
On the empty set, the statement is vacuously true: this lemma is used in leanprover-community#30083 to eliminate some superfluous non-emptiness hypotheses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocfnash ocfnash Awaiting requested review from ocfnash

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grunweg @ocfnash