[Merged by Bors] - ci: fix concurrency for pull request builds#31316
Closed
bryangingechen wants to merge 5 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - ci: fix concurrency for pull request builds#31316bryangingechen wants to merge 5 commits intoleanprover-community:masterfrom
bryangingechen wants to merge 5 commits intoleanprover-community:masterfrom
Conversation
PR summary 45aff7bccfImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
Thank: let's try it out! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
The issue (as [explained to me by Claude](https://claude.ai/share/9880d667-ff16-455f-b875-b273558d5256)) is apparently that `github.ref` for workflows triggered by `pull_request_target` is always `refs/heads/master`, so they all end up getting unique concurrency groups. I also add a step to print some build info to the logs, on the off chance that this still doesn't fix things. Follow-up to #31032 which was only a partial fix.
Contributor
|
Build failed: |
Contributor
Author
|
I forgot that our landrun shell doesn't pass on env variables. Hopefully just pasting the string with GitHub expressions works instead. |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
The issue (as [explained to me by Claude](https://claude.ai/share/9880d667-ff16-455f-b875-b273558d5256)) is apparently that `github.ref` for workflows triggered by `pull_request_target` is always `refs/heads/master`, so they all end up getting unique concurrency groups. I also add a step that ends up putting some build info in the logs, on the off chance that this still doesn't fix things. (Strictly speaking we don't log the data, we just put them in the env vars so that they are visible by expanding the "Run ..." details.) Follow-up to #31032 which was only a partial fix.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bryangingechen
added a commit
to bryangingechen/mathlib4
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue (as explained to me by Claude) is apparently that
github.reffor workflows triggered bypull_request_targetis alwaysrefs/heads/master, so they all end up getting unique concurrency groups.I also add a step that ends up putting some build info in the logs, on the off chance that this still doesn't fix things. (Strictly speaking we don't log the data, we just put them in the env vars so that they are visible by expanding the "Run ..." details.)
Follow-up to #31032 which was only a partial fix.