[Merged by Bors] - feat(LinearAlgebra/Multilinear): basis for multilinear maps#31178
Closed
morrison-daniel wants to merge 90 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(LinearAlgebra/Multilinear): basis for multilinear maps#31178morrison-daniel wants to merge 90 commits intoleanprover-community:masterfrom
morrison-daniel wants to merge 90 commits intoleanprover-community:masterfrom
Conversation
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…community/mathlib4 into SM.PiTensorProduct.DirectSum
…community/mathlib4 into SM.PiTensorProduct.DirectSum
Co-authored-by: Eric Wieser <efw@google.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
ocfnash
reviewed
Dec 2, 2025
Contributor
ocfnash
left a comment
There was a problem hiding this comment.
There is a lot of good material here but this is quite difficult to review because several independent changes are being made.
However I think there is a clear path forward simply by splitting up the PR. I suggest starting by opening a new PR which contains the minimum subset of this PR necessary to add Basis.multilinearMap (and its API) and then we iterate to add the next piece.
What do you think?
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Collaborator
Author
|
I've removed anything not needed for construction of the basis, and I'll create two more PRs. |
ocfnash
reviewed
Dec 3, 2025
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Collaborator
Author
|
Included review changes and merged master. |
ocfnash
approved these changes
Dec 4, 2025
Contributor
ocfnash
left a comment
There was a problem hiding this comment.
Thanks very much for all your work here!
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Adds a basis for MulilinearMap given bases for the domain and codomain. This PR builds upon work started in #25141 toward #11155. Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Oliver Nash <github@olivernash.org>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basis for MulilinearMap given bases for the domain and codomain.
This PR builds upon work started in #25141 toward #11155.