Skip to content

[Merged by Bors] - feat: port Algebra.MonoidAlgebra.Ideal#3106

Closed
newell wants to merge 6 commits intomasterfrom
port/Algebra.MonoidAlgebra.Ideal
Closed

[Merged by Bors] - feat: port Algebra.MonoidAlgebra.Ideal#3106
newell wants to merge 6 commits intomasterfrom
port/Algebra.MonoidAlgebra.Ideal

Conversation

@newell
Copy link
Copy Markdown
Collaborator

@newell newell commented Mar 26, 2023


Open in Gitpod

newell added 3 commits March 25, 2023 21:48
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@newell newell added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 26, 2023
constructor
· revert x
refine' Ideal.span_le.2 _
rw [←SetLike.le_def] -- porting note: refine needs this even though it's defeq?
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is weird too, and possibly worth a zulip thread.

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review and removed WIP Work in progress labels Apr 12, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 20, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Apr 21, 2023

bors merge

bors bot pushed a commit that referenced this pull request Apr 21, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Apr 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.MonoidAlgebra.Ideal [Merged by Bors] - feat: port Algebra.MonoidAlgebra.Ideal Apr 21, 2023
@bors bors bot closed this Apr 21, 2023
@bors bors bot deleted the port/Algebra.MonoidAlgebra.Ideal branch April 21, 2023 04:11
kbuzzard pushed a commit that referenced this pull request Apr 22, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em pushed a commit that referenced this pull request May 10, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants