Skip to content

[Merged by Bors] - feat(Topology/Sets): Singleton instances for (Nonempty)Compacts#31035

Closed
gasparattila wants to merge 1 commit intoleanprover-community:masterfrom
gasparattila:compacts-singleton
Closed

[Merged by Bors] - feat(Topology/Sets): Singleton instances for (Nonempty)Compacts#31035
gasparattila wants to merge 1 commit intoleanprover-community:masterfrom
gasparattila:compacts-singleton

Conversation

@gasparattila
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Oct 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2025

PR summary d7739e45ae

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : Singleton α (Compacts α)
+ instance : Singleton α (NonemptyCompacts α)
+ map_singleton
+ toCloseds_singleton
+ toCompacts_singleton
++ mem_singleton
++ singleton_prod_singleton

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 29, 2025

✌️ gasparattila can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 29, 2025
@ADedecker
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 29, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Sets): Singleton instances for (Nonempty)Compacts [Merged by Bors] - feat(Topology/Sets): Singleton instances for (Nonempty)Compacts Oct 29, 2025
@mathlib-bors mathlib-bors bot closed this Oct 29, 2025
gasparattila added a commit to gasparattila/mathlib4 that referenced this pull request Nov 2, 2025
…eds`

This allows generating several lemmas about `NonemptyCompacts.toCompacts` using `simps`. Only two lemmas added in leanprover-community#31035 need to be renamed.
gasparattila added a commit to gasparattila/mathlib4 that referenced this pull request Nov 2, 2025
…eds`

This allows generating some lemmas about `NonemptyCompacts.toCompacts` using `simps`. Only two lemmas added in leanprover-community#31035 need to be renamed.
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants