[Merged by Bors] - chore: shortcut instance for Nat to be mul-torsion-free#31027
Closed
YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: shortcut instance for Nat to be mul-torsion-free#31027YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Nat to be mul-torsion-free#31027YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
7 tasks
PR summary 8c36f10cbaImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
plp127
reviewed
Oct 29, 2025
ac429cf to
7e47398
Compare
7e47398 to
79fbb2e
Compare
This instance can already be found by typeclass search using the fact that `Nat` is a `LinearOrderedCommMonoidWithZero`, but it is better practice to not rely on algebraic order theory to prove algebraic results about such basic types. Similarly for `IsAddTorsionFree Int`.
79fbb2e to
728f920
Compare
kckennylau
approved these changes
Nov 21, 2025
Comment on lines
+51
to
+52
| instance instIsAddTorsionFree : IsAddTorsionFree ℤ where | ||
| nsmul_right_injective _n hn _x _y := Int.eq_of_mul_eq_mul_left (by cutsat) |
Collaborator
There was a problem hiding this comment.
Suggested change
| instance instIsAddTorsionFree : IsAddTorsionFree ℤ where | |
| nsmul_right_injective _n hn _x _y := Int.eq_of_mul_eq_mul_left (by cutsat) | |
| instance instIsAddTorsionFree : IsAddTorsionFree ℤ where | |
| nsmul_right_injective _n hn _x _y := Int.eq_of_mul_eq_mul_left <| ofNat_ne_zero.mpr hn |
(optional)
Contributor
Author
There was a problem hiding this comment.
Oh, I'm pretty sure Kim would prefer us to use cutsat here
Contributor
|
Please add comments to the shortcut instances explaining why they exist. bors d+ |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2025
This instance can already be found by typeclass search using the fact that `Nat` is a `LinearOrderedCommMonoidWithZero`, but it is better practice to not rely on algebraic order theory to prove algebraic results about such basic types. Similarly for `IsAddTorsionFree Int`. From ClassFieldTheory
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Nat to be mul-torsion-freeNat to be mul-torsion-free
alok
added a commit
to alok/mathlib4
that referenced
this pull request
Mar 17, 2026
…lib4 * 'master' of https://github.com/leanprover-community/mathlib4: (3130 commits) feat(SetTheory/ZFC): add `ZFSet.card` (leanprover-community#29365) feat: grind annotations for `choose_spec` (leanprover-community#31927) chore(scripts): update nolints.json (leanprover-community#31975) feat(Analysis): cos (n * π) = (-1) ^ n (leanprover-community#31971) chore: rename `mul_le_mul_right'` to `mul_le_mul_left` (leanprover-community#30242) chore: update Mathlib dependencies 2025-11-22 (leanprover-community#31955) feat(MeasureTheory): ae-measurability notation wrt non-standard sigma-algebra (leanprover-community#31910) doc: add missing spaces around doc code blocks (leanprover-community#31917) chore: update Mathlib dependencies 2025-11-22 (leanprover-community#31945) chore: shortcut instance for `Nat` to be mul-torsion-free (leanprover-community#31027) doc(Topology/Algebra/Algebra): outdated TODO (leanprover-community#31944) feat(EqHaar): add `addHaar_nnreal_smul` (leanprover-community#31922) chore(Algebra): make invertibleInv an instance (leanprover-community#31916) chore(Algebra): change two statements in CubicDiscriminant (leanprover-community#31912) chore(MeasureTheory): mark `map_dirac` as simp (leanprover-community#31909) feat: `LinearOrder` instance for `Empty` (leanprover-community#31889) chore: deprecate all remaining modules in `Analysis/NormedSpace` (leanprover-community#31913) feat(SimpleGraph): weaker condition for paths in acyclic graphs (leanprover-community#25814) chore: do not set `group` when declaring option (leanprover-community#31888) chore: clean up more unused `Decidable*` instances in types (leanprover-community#31934) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This instance can already be found by typeclass search using the fact that
Natis aLinearOrderedCommMonoidWithZero, but it is better practice to not rely on algebraic order theory to prove algebraic results about such basic types. Similarly forIsAddTorsionFree Int.From ClassFieldTheory