Skip to content

[Merged by Bors] - chore: remove some unused variables#31017

Closed
Ruben-VandeVelde wants to merge 2 commits intoleanprover-community:masterfrom
Ruben-VandeVelde:bigoperators-variables
Closed

[Merged by Bors] - chore: remove some unused variables#31017
Ruben-VandeVelde wants to merge 2 commits intoleanprover-community:masterfrom
Ruben-VandeVelde:bigoperators-variables

Conversation

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2025

PR summary 31f931fed0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 28, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small error, otherwise looks good!

maintainer delegate

section Mul

variable [Mul M] [One M] {l : List M} {a : M}
variable [Mul M] [One M] {a : M} {l : List M}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why swap these? I usually like to put the most bundled ones first

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to not change the signature of prod_cons (which is the only one that uses a in this section); I'd rather avoid any visible changes in this PR, even if it's quite unlikely that it'd affect anything in this case.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but you are changing the signature of other lemmas instead, so I don't really see the point

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I guess there are no other lemmas in this instance. Still, I wouldn't bother

@YaelDillies
Copy link
Copy Markdown
Contributor

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 29, 2025
Copy link
Copy Markdown
Contributor

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🐙

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 29, 2025
@ghost ghost removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 29, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove some unused variables [Merged by Bors] - chore: remove some unused variables Oct 29, 2025
@mathlib-bors mathlib-bors bot closed this Oct 29, 2025
@Ruben-VandeVelde Ruben-VandeVelde deleted the bigoperators-variables branch October 29, 2025 09:03
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants