Skip to content

[Merged by Bors] - chore: deprecate frobenius_xxx lemmas#31014

Closed
kckennylau wants to merge 4 commits intoleanprover-community:masterfrom
kckennylau:deprecate-frobenius-lemmas
Closed

[Merged by Bors] - chore: deprecate frobenius_xxx lemmas#31014
kckennylau wants to merge 4 commits intoleanprover-community:masterfrom
kckennylau:deprecate-frobenius-lemmas

Conversation

@kckennylau
Copy link
Copy Markdown
Collaborator

e.g. frobenius_add should be replaced with map_add _.


Open in Gitpod

@kckennylau kckennylau requested a review from pechersky October 28, 2025 15:48
@pechersky
Copy link
Copy Markdown
Contributor

Let's watch what complains

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2025

PR summary 31f931fed0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@pechersky
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by pechersky.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 28, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 8ad219c.
There were no significant changes against commit 31f931f.

@github-actions
Copy link
Copy Markdown

File Instructions %
build +1.610⬝10⁹ (+0.00%)
Mathlib.Data.List.Map2 +1.51⬝10⁹ (+12.88%)
CI run Lakeprof report

@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Oct 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 29, 2025
e.g. `frobenius_add` should be replaced with `map_add _`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: deprecate frobenius_xxx lemmas [Merged by Bors] - chore: deprecate frobenius_xxx lemmas Oct 29, 2025
@mathlib-bors mathlib-bors bot closed this Oct 29, 2025
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
e.g. `frobenius_add` should be replaced with `map_add _`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants