Skip to content

refactor: disable simp in measurability#30966

Draft
gasparattila wants to merge 1 commit intoleanprover-community:masterfrom
gasparattila:measurability-no-simp
Draft

refactor: disable simp in measurability#30966
gasparattila wants to merge 1 commit intoleanprover-community:masterfrom
gasparattila:measurability-no-simp

Conversation

@gasparattila
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 27, 2025

PR summary 3e58cbedd7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Oct 27, 2025

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit ad0ccb1.
There were no significant changes against commit 6d6ec67.

@github-actions
Copy link
Copy Markdown

File Instructions %
build -58.480⬝10⁹ (-0.03%)
3 files, Instructions -2.0⬝10⁹
File Instructions %
Mathlib.MeasureTheory.Measure.Decomposition.Lebesgue -1.112⬝10⁹ (-1.93%)
Mathlib.Probability.Kernel.Disintegration.Density -1.206⬝10⁹ (-2.82%)
Mathlib.MeasureTheory.VectorMeasure.Basic -1.913⬝10⁹ (-3.55%)
File Instructions %
Mathlib.MeasureTheory.Measure.Typeclasses.Finite -2.143⬝10⁹ (-7.68%)
Mathlib.Algebra.Homology.HomotopyCategory.Pretriangulated -4.455⬝10⁹ (-2.84%)
Mathlib.Probability.Kernel.Proper -5.739⬝10⁹ (-10.22%)
2 files, Instructions -7.0⬝10⁹
File Instructions %
Mathlib.MeasureTheory.VectorMeasure.Decomposition.Hahn -6.705⬝10⁹ (-24.41%)
Mathlib.MeasureTheory.Function.UnifTight -6.711⬝10⁹ (-23.72%)

CI run Lakeprof report

mathlib-bors bot pushed a commit that referenced this pull request Oct 29, 2025
In some cases, add `≠ ∞` versions of existing `< ∞` lemmas, and tag those with finiteness.
Use this to golf one proof `by measurability` using finiteness, which is the morally correct proof.
Motivated by #30966.
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 29, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@gasparattila gasparattila force-pushed the measurability-no-simp branch from ad0ccb1 to 11c1cb1 Compare October 29, 2025 19:00
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 29, 2025
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…ver-community#30967)

In some cases, add `≠ ∞` versions of existing `< ∞` lemmas, and tag those with finiteness.
Use this to golf one proof `by measurability` using finiteness, which is the morally correct proof.
Motivated by leanprover-community#30966.
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 10, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 13, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 3, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants