Skip to content

[Merged by Bors] - feat(SetTheory/ZFC): add ZFSet.iUnion#30841

Closed
staroperator wants to merge 5 commits intoleanprover-community:masterfrom
staroperator:zfset_iUnion
Closed

[Merged by Bors] - feat(SetTheory/ZFC): add ZFSet.iUnion#30841
staroperator wants to merge 5 commits intoleanprover-community:masterfrom
staroperator:zfset_iUnion

Conversation

@staroperator
Copy link
Copy Markdown
Collaborator

@staroperator staroperator commented Oct 24, 2025 •
edited
Loading

which is just sUnion (range f). We add a new definition for it instead of making ⋃ i, f i a notation of sUnion (range f), because the simp normal form of (sUnion (range f)).toSet is not ⋃ i, (f i).toSet.

Open in Gitpod

@staroperator staroperator mentioned this pull request Oct 24, 2025
Closed
2 tasks
@github-actions github-actions bot added the t-set-theory Set theory label Oct 24, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 24, 2025 •
edited
Loading

PR summary e37e4dc730

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsTransitive.iUnion
+ iUnion
+ mem_iUnion
+ rank_iUnion
+ subset_iUnion
+ toSet_iUnion

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

YaelDillies
YaelDillies reviewed Oct 24, 2025
View reviewed changes
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 24, 2025
@staroperator staroperator added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Oct 24, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Oct 24, 2025
YaelDillies
YaelDillies approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks very nice.

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 24, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 24, 2025
@staroperator staroperator reopened this Oct 24, 2025
vihdzp
vihdzp reviewed Oct 25, 2025
View reviewed changes
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Nov 4, 2025

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 4, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 4, 2025
@staroperator
feat(SetTheory/ZFC): add ZFSet.iUnion (#30841)
9217ddd 
which is just `sUnion (range f)`.  We add a new definition for it instead of making `⋃ i, f i` a notation of `sUnion (range f)`, because the simp normal form of `(sUnion (range f)).toSet` is not `⋃ i, (f i).toSet`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 4, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(SetTheory/ZFC): add ZFSet.iUnion [Merged by Bors] - feat(SetTheory/ZFC): add ZFSet.iUnion Nov 4, 2025
@mathlib-bors mathlib-bors bot closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

+1 more reviewer

@vihdzp vihdzp vihdzp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alreadydone alreadydone

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@staroperator @ocfnash @YaelDillies @vihdzp @alreadydone