[Merged by Bors] - chore: use FunLike.coe as coercion for OrderIso and RelEmbedding#3082
Closed
ChrisHughes24 wants to merge 23 commits intomasterfrom
Closed
[Merged by Bors] - chore: use FunLike.coe as coercion for OrderIso and RelEmbedding#3082ChrisHughes24 wants to merge 23 commits intomasterfrom
ChrisHughes24 wants to merge 23 commits intomasterfrom
Conversation
1 task
Contributor
|
@ChrisHughes24, would you be able to write an explanation of what you're doing, and why, in the PR description? (Or linking to zulip as appropriate?) |
eric-wieser
reviewed
Apr 1, 2023
2 tasks
ChrisHughes24
commented
Apr 1, 2023
b7c32e6 to
5d84509
Compare
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
The changes I made were. Use `FunLike.coe` instead of the previous definition for the coercion from `RelEmbedding` To functions and `OrderIso` to functions. The previous definition was ```lean instance : CoeFun (r ↪r s) fun _ => α → β := -- ⟨fun o => o.toEmbedding⟩ ``` This does not display nicely. I also restored the `simp` attributes on a few lemmas that had their `simp` attributes removed during the port. Eventually we might want a `RelEmbeddingLike` class, but this PR does not implement that. I also added a few lemmas that proved that coercions to function commute with `RelEmbedding.toRelHom` or similar. The other changes are just fixing the build. One strange issue is that the lemma `Finset.mapEmbedding_apply` seems to be harder to use, it has to be used with `rw` instead of `simp` Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
The changes I made were. Use `FunLike.coe` instead of the previous definition for the coercion from `RelEmbedding` To functions and `OrderIso` to functions. The previous definition was ```lean instance : CoeFun (r ↪r s) fun _ => α → β := -- ⟨fun o => o.toEmbedding⟩ ``` This does not display nicely. I also restored the `simp` attributes on a few lemmas that had their `simp` attributes removed during the port. Eventually we might want a `RelEmbeddingLike` class, but this PR does not implement that. I also added a few lemmas that proved that coercions to function commute with `RelEmbedding.toRelHom` or similar. The other changes are just fixing the build. One strange issue is that the lemma `Finset.mapEmbedding_apply` seems to be harder to use, it has to be used with `rw` instead of `simp` Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Apr 22, 2023
The changes I made were. Use `FunLike.coe` instead of the previous definition for the coercion from `RelEmbedding` To functions and `OrderIso` to functions. The previous definition was ```lean instance : CoeFun (r ↪r s) fun _ => α → β := -- ⟨fun o => o.toEmbedding⟩ ``` This does not display nicely. I also restored the `simp` attributes on a few lemmas that had their `simp` attributes removed during the port. Eventually we might want a `RelEmbeddingLike` class, but this PR does not implement that. I also added a few lemmas that proved that coercions to function commute with `RelEmbedding.toRelHom` or similar. The other changes are just fixing the build. One strange issue is that the lemma `Finset.mapEmbedding_apply` seems to be harder to use, it has to be used with `rw` instead of `simp` Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
kim-em
pushed a commit
that referenced
this pull request
May 10, 2023
The changes I made were. Use `FunLike.coe` instead of the previous definition for the coercion from `RelEmbedding` To functions and `OrderIso` to functions. The previous definition was ```lean instance : CoeFun (r ↪r s) fun _ => α → β := -- ⟨fun o => o.toEmbedding⟩ ``` This does not display nicely. I also restored the `simp` attributes on a few lemmas that had their `simp` attributes removed during the port. Eventually we might want a `RelEmbeddingLike` class, but this PR does not implement that. I also added a few lemmas that proved that coercions to function commute with `RelEmbedding.toRelHom` or similar. The other changes are just fixing the build. One strange issue is that the lemma `Finset.mapEmbedding_apply` seems to be harder to use, it has to be used with `rw` instead of `simp` Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes I made were.
Use
FunLike.coeinstead of the previous definition for the coercion fromRelEmbeddingTo functions andOrderIsoto functions. The previous definition wasThis does not display nicely.
I also restored the
simpattributes on a few lemmas that had theirsimpattributes removed during the port. Eventuallywe might want a
RelEmbeddingLikeclass, but this PR does not implement that.I also added a few lemmas that proved that coercions to function commute with
RelEmbedding.toRelHomor similar.The other changes are just fixing the build. One strange issue is that the lemma
Finset.mapEmbedding_applyseems to be harder to use, it has to be used withrwinstead ofsimp