Skip to content

[Merged by Bors] - feat: sync Data.Set.Intervals.OrdConnected#3077

Closed
joneugster wants to merge 2 commits intomasterfrom
sync_data.set.intervals.ord_connected
Closed

[Merged by Bors] - feat: sync Data.Set.Intervals.OrdConnected#3077
joneugster wants to merge 2 commits intomasterfrom
sync_data.set.intervals.ord_connected

Conversation

@joneugster
Copy link
Copy Markdown
Contributor


This matches the way it is in mathlib3, but is it correct that the new statement is Set.IsAntichain.ordConnected instead of IsAntichain.ordConnected?

Open in Gitpod

@joneugster joneugster added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Mar 24, 2023
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented Mar 24, 2023

This matches the way it is in mathlib3, but is it correct that the new statement is Set.IsAntichain.ordConnected instead of IsAntichain.ordConnected?

no, mathport doesn't know about _root_.

@eric-wieser eric-wieser requested a review from YaelDillies March 24, 2023 19:18
@YaelDillies
Copy link
Copy Markdown
Contributor

Uh oh. Let me fix that quick.

@YaelDillies
Copy link
Copy Markdown
Contributor

maintainer merge

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Mar 26, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 26, 2023
bors bot pushed a commit that referenced this pull request Mar 27, 2023
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Mar 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: sync Data.Set.Intervals.OrdConnected [Merged by Bors] - feat: sync Data.Set.Intervals.OrdConnected Mar 27, 2023
@bors bors bot closed this Mar 27, 2023
@bors bors bot deleted the sync_data.set.intervals.ord_connected branch March 27, 2023 01:41
bors bot pushed a commit that referenced this pull request Mar 27, 2023
The change to `Mathlib/Data/Set/Intervals/OrdConnected.lean` was already forward-ported in #3077.

Also fixes a remaining `simple_graph` in the comments of one of the files.



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants