Skip to content

[Merged by Bors] - chore: remove @[gcongr] from opow_le_opow_right#30651

Closed
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-opow_le_opow
Closed

[Merged by Bors] - chore: remove @[gcongr] from opow_le_opow_right#30651
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-opow_le_opow

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

This tag was accidentally added in #30508, but it is redundant


Open in Gitpod

@github-actions github-actions bot added the t-set-theory Set theory label Oct 18, 2025
@github-actions
Copy link
Copy Markdown

PR summary a77a0aeac5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Oct 18, 2025

Thanks for following up on this! Should the tag on opow_le_opow_left also be removed?

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 18, 2025
@grunweg grunweg self-assigned this Oct 18, 2025
@JovanGerb
Copy link
Copy Markdown
Contributor Author

opow_le_opow_left doesn't have any side conditions, so it deserves a @[gcongr] tag. On the other hand, opow_le_opow_right and opow_le_opow have the same side condition, so we can just tag the most general of the two.

@JovanGerb JovanGerb removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 18, 2025
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Oct 18, 2025

Makes sense, thanks! (Is anything of that documented? It would be nice to not have to ask you about gcongr all the time...)

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Oct 18, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 18, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2025
This tag was accidentally added in #30508, but it is redundant
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove @[gcongr] from opow_le_opow_right [Merged by Bors] - chore: remove @[gcongr] from opow_le_opow_right Oct 18, 2025
@mathlib-bors mathlib-bors bot closed this Oct 18, 2025
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 24, 2025
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants