feat: add custom elaborators for immersions#30504
feat: add custom elaborators for immersions#30504grunweg wants to merge 41 commits intoleanprover-community:masterfrom
Conversation
PR summary 54bd5cb866
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Geometry.Manifold.Immersion | 1964 | 1973 | +9 (+0.46%) |
| Mathlib.Geometry.Manifold.ContMDiff.Atlas | 1954 | 1957 | +3 (+0.15%) |
| Mathlib.Geometry.Manifold.SmoothEmbedding | 1990 | 1991 | +1 (+0.05%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Geometry.Manifold.SmoothEmbedding |
1 |
Mathlib.Geometry.Manifold.ContMDiff.Atlas |
3 |
Mathlib.Geometry.Manifold.Immersion |
9 |
Declarations diff
+ ContDiffWithinAt.fst
+ ContDiffWithinAt.snd
+ contDiffAt_prod_iff
+ contDiffOn_prod_iff
+ contDiffWithinAt_prod_iff
+ contDiff_prod_iff
+ contMDiffOn_extend
+ contMDiffOn_writtenInExtend_iff
+ contMDiffWithinAt_writtenInExtend_iff
+ extend_target_eq_image_source
+ instance (h : IsImmersion% n f) : NormedAddCommGroup h.complement
+ instance (h : IsImmersion% n f) : NormedSpace 𝕜 h.complement
+ instance (h : IsImmersionAt% n f x) : NormedAddCommGroup h.complement := by
+ instance (h : IsImmersionAt% n f x) : NormedSpace 𝕜 h.complement := by
+ instance (hf : IsImmersionAtOfComplement% F n f x) : NormedAddCommGroup hf.smallComplement := by
+ instance (hf : IsImmersionAtOfComplement% F n f x) : NormedSpace 𝕜 hf.smallComplement := by
++ contMDiffAt
++ contMDiffOn
++ continuousAt
++ continuousOn
++ mapsto_domChart_source_codChart_source
+++ contMDiff
- instance (h : IsImmersion I J n f) : NormedAddCommGroup h.complement
- instance (h : IsImmersion I J n f) : NormedSpace 𝕜 h.complement
- instance (h : IsImmersionAt I J n f x) : NormedAddCommGroup h.complement := by
- instance (h : IsImmersionAt I J n f x) : NormedSpace 𝕜 h.complement := by
- instance (hf : IsImmersionAtOfComplement F I J n f x) : NormedAddCommGroup hf.smallComplement := by
- instance (hf : IsImmersionAtOfComplement F I J n f x) : NormedSpace 𝕜 hf.smallComplement := by
-+-+ codChart
-+-+ codChart_mem_maximalAtlas
-+-+ complement
-+-+ congr_of_eventuallyEq
-+-+ domChart
-+-+ domChart_mem_maximalAtlas
-+-+ equiv
-+-+ isImmersionAt
-+-+ map_target_subset_target
-+-+ mem_codChart_source
-+-+ mem_domChart_source
-+-+ property
-+-+ target_subset_preimage_target
-+-+ writtenInCharts
-+-++- source_subset_preimage_source
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
a233946 to
9af275f
Compare
|
This pull request has conflicts, please merge |
9af275f to
30174e5
Compare
|
This pull request has conflicts, please merge |
Use I and J consistently. Also add further variables for use when adding products.
There are a bunch of CI warnings, which are all false positives.
Co-authored-by: Christian Merten <christian@merten.dev>
This reverts commit 1b7b2e0.
Co-authored-by: Christian Merten <christian@merten.dev>
With an AI attempt as a starting point; cleaned up by me.
Co-authored-by: Christian Merten <christian@merten.dev>
And golf the fail using it, a bit. Other usage sites expose bugs or unexpected error messages... TODO: add basic tests for basic usage TODO: fix those errors (then try to golf further!
b3838c2 to
0d97a66
Compare
|
This pull request has conflicts, please merge |
And golf the fail using it, a bit. Other usage sites expose bugs or unexpected error messages...
TODO: add basic tests for basic usage
TODO: fix those errors (then try to golf further!