Skip to content

[Merged by Bors] - feat: the set of points where IsImmersionAt(OfComplement) holds is open #30356

Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:immersions-followup
Closed

[Merged by Bors] - feat: the set of points where IsImmersionAt(OfComplement) holds is open #30356
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg:immersions-followup

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Oct 9, 2025

Prove an API lemma which chrisflav requested in #28793, which was split from that PR to keep the diff smaller.


Open in Gitpod

@grunweg grunweg changed the title Follow-up to #289793. feat: follow-up to #28793 Oct 9, 2025
@github-actions github-actions bot added the t-differential-geometry Manifolds etc label Oct 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

PR summary fc14f3da77

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.IsOpen.isImmersionAt
+ _root_.IsOpen.isImmersionAtOfComplement
+ _root_.IsOpen.liftSourceTargetPropertyAt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 9, 2025
@grunweg grunweg force-pushed the immersions-followup branch from e84a18d to 8bafa11 Compare October 11, 2025 20:54
@grunweg grunweg mentioned this pull request Oct 30, 2025
1 task
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 28, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@grunweg grunweg force-pushed the immersions-followup branch from 8bafa11 to f259784 Compare November 28, 2025 21:10
@grunweg grunweg changed the title feat: follow-up to #28793 feat: the set of points where IsImmersionAt(OfComplement) holds is open Nov 28, 2025
@grunweg grunweg removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 28, 2025
@github-actions
Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

error: the PR title should be of the form
  abbrev: main title
or
  abbrev(scope): main title
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 28, 2025

@chrisflav Here's the missing API lemma you asked for, on #28793. Feel free to review (but not obliged, I can easily ask somebody else).

@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 28, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 28, 2025

The failing PR title check is a bug in the checker...

@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 28, 2025
Comment on lines +199 to +200
/- The set of points where `LiftSourceTargetPropertyAt` holds is open. -/
lemma _root_.isOpen_liftSourceTargetPropertyAt :
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the _root_ namespace? For dot notation, this one could be in the IsSourceLocalTargetProperty namespace. Or in IsOpen for anonymous dot notation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about a natural namespace. I have moved it to isOpen now.

@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 29, 2025

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2025
@grunweg grunweg added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 29, 2025
Copy link
Copy Markdown
Member

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 29, 2025
@sgouezel
Copy link
Copy Markdown
Contributor

bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 30, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 30, 2025
…pen (#30356)

Prove an API lemma which `chrisflav` requested in #28793, which was split from that PR to keep the diff smaller.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 30, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the set of points where IsImmersionAt(OfComplement) holds is open [Merged by Bors] - feat: the set of points where IsImmersionAt(OfComplement) holds is open Nov 30, 2025
@mathlib-bors mathlib-bors bot closed this Nov 30, 2025
@grunweg grunweg deleted the immersions-followup branch November 30, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants