[Merged by Bors] - chore: split test file for differential geometry elaborators#30412
Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: split test file for differential geometry elaborators#30412grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 6652a12058Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
This was referenced Oct 10, 2025
Collaborator
|
This pull request has conflicts, please merge |
c6a0834 to
5755031
Compare
5755031 to
7b4fe0b
Compare
1 task
The test file was getting quite long (with more tests to come for future features), and accumulating too many imports: once mathlib was tweaked to make use of the elaborators, recompilation after a basic change would take too long. Split it into a basic file with minimal imports, and another file for all more advanced features.
7b4fe0b to
f8e3518
Compare
Collaborator
|
This PR/issue depends on: |
thorimur
reviewed
Oct 15, 2025
Comment on lines
+8
to
+12
| import Mathlib.Geometry.Manifold.VectorField.LieBracket | ||
| /-! | ||
| # Tests for the differential geometry elaborators which require stronger imports | ||
|
|
||
| -/ |
Contributor
There was a problem hiding this comment.
Suggested change
| import Mathlib.Geometry.Manifold.VectorField.LieBracket | |
| /-! | |
| # Tests for the differential geometry elaborators which require stronger imports | |
| -/ | |
| import Mathlib.Geometry.Manifold.VectorField.LieBracket | |
| /-! | |
| # Tests for the differential geometry elaborators which require stronger imports | |
| -/ |
Contributor
Author
There was a problem hiding this comment.
Thanks for the quick review! I have change the second part of your suggestion, but not the first one: my impression is that including a blank line between the imports and module doc-string is actually much more common in mathlib.
Let's check: searching for import \S*\n/-! in VS Code yields 186 hits, whereas there are 6802 hits for import \S*\n\n/-! (with a newline in between), and 18 for two blank lines. So, I'll stay with the vast mathlib majority here.
Contributor
Author
There was a problem hiding this comment.
(I'd review a PR normalising the 18 files with excessive newlines. You could try proposing a style rule on this; I'm not sure if this gets into excessive bikeshedding or not. The different is large enough that this might be fine.)
Contributor
|
I double-checked, and all of the tests indeed seem to have made it through the split in one piece! :) maintainer delegate |
|
🚀 Pull request has been placed on the maintainer queue by thorimur. |
Contributor
|
Thanks! |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
The test file was getting quite long (with more tests to come for future features), and accumulating too many imports: once mathlib was tweaked to make use of the elaborators, recompilation after a basic change would take too long. Split it into a basic file with minimal imports, and another file for all more advanced features.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Jlh18
pushed a commit
to Jlh18/mathlib4
that referenced
this pull request
Oct 24, 2025
…ver-community#30412) The test file was getting quite long (with more tests to come for future features), and accumulating too many imports: once mathlib was tweaked to make use of the elaborators, recompilation after a basic change would take too long. Split it into a basic file with minimal imports, and another file for all more advanced features.
BeibeiX0
pushed a commit
to BeibeiX0/mathlib4
that referenced
this pull request
Nov 7, 2025
…ver-community#30412) The test file was getting quite long (with more tests to come for future features), and accumulating too many imports: once mathlib was tweaked to make use of the elaborators, recompilation after a basic change would take too long. Split it into a basic file with minimal imports, and another file for all more advanced features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test file was getting quite long (with more tests to come for future features), and accumulating too many imports: once mathlib was tweaked to make use of the elaborators, recompilation after a basic change would take too long.
Split it into a basic file with minimal imports, and another file for all more advanced features.