Skip to content

[Merged by Bors] - feat(Algebra/HahnEmbedding): ArchimedeanStrata is non-empty#30101

Closed
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:wwylele-hahn-nonempty
Closed

[Merged by Bors] - feat(Algebra/HahnEmbedding): ArchimedeanStrata is non-empty#30101
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:wwylele-hahn-nonempty

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Sep 30, 2025

This is a small part of #27268 (Hahn embedding theorem). Separated out for easy review while waiting for the other dependency.


Open in Gitpod

@wwylele wwylele force-pushed the wwylele-hahn-nonempty branch from 5506d37 to 59ef8ff Compare September 30, 2025 22:27
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 30, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Sep 30, 2025
@wwylele wwylele force-pushed the wwylele-hahn-nonempty branch from 59ef8ff to 2925930 Compare September 30, 2025 22:28
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 30, 2025

PR summary 213ff10ae9

Import changes exceeding 2%

% File
+2.75% Mathlib.Algebra.Order.Module.HahnEmbedding

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Module.HahnEmbedding 1089 1119 +30 (+2.75%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Order.Module.HahnEmbedding 30

Declarations diff

+ instance : Nonempty (ArchimedeanStrata K M) := by

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 4, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 4, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 9, 2025
This is a small part of #27268 (Hahn embedding theorem). Separated out for easy review while waiting for the other dependency.
@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Oct 9, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/HahnEmbedding): ArchimedeanStrata is non-empty [Merged by Bors] - feat(Algebra/HahnEmbedding): ArchimedeanStrata is non-empty Oct 9, 2025
@mathlib-bors mathlib-bors bot closed this Oct 9, 2025
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 14, 2025
…er-community#30101)

This is a small part of leanprover-community#27268 (Hahn embedding theorem). Separated out for easy review while waiting for the other dependency.
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…er-community#30101)

This is a small part of leanprover-community#27268 (Hahn embedding theorem). Separated out for easy review while waiting for the other dependency.
@wwylele wwylele deleted the wwylele-hahn-nonempty branch November 20, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants