Skip to content

[Merged by Bors] - fix: add incorrectly-deleted lemmas#3008

Closed
eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser/fix-Algebra.Ring.Equiv
Closed

[Merged by Bors] - fix: add incorrectly-deleted lemmas#3008
eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser/fix-Algebra.Ring.Equiv

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

These lemmas are still needed in Lean 4, despite claims in #1077 that they are not.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Mar 21, 2023
@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

Parcly-Taxel commented Mar 21, 2023

Doing simp? on the offending declaration in #3007 reveals that ring_equiv.to_fun_eq_coe is likely the lemma that should be restored, not the two already restored.

Try this: simp only [free_algebra.star_algebra_map,
 mul_opposite.algebra_map_apply,
 ring_equiv.to_fun_eq_coe,
 eq_self_iff_true,
 mul_opposite.op_inj,
 star_ring_equiv_apply,
 free_algebra.algebra_map_inj]

@eric-wieser
Copy link
Copy Markdown
Member Author

Can you try with squeeze_simp?

@eric-wieser
Copy link
Copy Markdown
Member Author

eric-wieser commented Mar 21, 2023

You're right though; ring_equiv.to_fun_eq_coe should be restored too edit: nevermind. Lean3's some_ring_equiv.to_fun is lean 4's some_ring_equiv.to_equiv.to_fun; so dropping ring_equiv.to_fun_eq_coe was correct

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

Can you try with squeeze_simp?

It returns

Try this: simp only [star_algebra_map, ring_equiv.to_fun_eq_coe, star_ring_equiv_apply, mul_opposite.algebra_map_apply]

@eric-wieser
Copy link
Copy Markdown
Member Author

See my edit above. ring_equiv.to_fun_eq_coe has been replaced by equiv.to_fun_eq_coe and ring_equiv.coe_to_equiv in Lean 4, since ring_equiv.to_fun no longer exists

@eric-wieser eric-wieser removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 21, 2023
@eric-wieser eric-wieser requested a review from RemyDegenne March 21, 2023 18:20
@RemyDegenne
Copy link
Copy Markdown
Contributor

LGTM
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 21, 2023
bors bot pushed a commit that referenced this pull request Mar 21, 2023
These lemmas are still needed in Lean 4, despite claims in #1077 that they are not.
@bors
Copy link
Copy Markdown

bors bot commented Mar 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: add incorrectly-deleted lemmas [Merged by Bors] - fix: add incorrectly-deleted lemmas Mar 21, 2023
@bors bors bot closed this Mar 21, 2023
@bors bors bot deleted the eric-wieser/fix-Algebra.Ring.Equiv branch March 21, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants