Skip to content

[Merged by Bors] - feat(push): @[push] annotations for fun#30038

Closed
JovanGerb wants to merge 4 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-push-fun
Closed

[Merged by Bors] - feat(push): @[push] annotations for fun#30038
JovanGerb wants to merge 4 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-push-fun

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Sep 27, 2025

This PR adds the annotations for the tactics push fun _ ↦ _ and pull fun _ ↦ _ and the simprocs pushFun and pullFun.

The following operations are supported: 1, 0, *, +, ⁻¹, -, /, ^, , +ᵥ, -ᵥ, star, ofNat, natCast, intCast, , , | |, , , , , , , \, default, algebraMap, kstar, ⌊/⌋, , , ⁺ᵐ, ⁻ᵐ.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 27, 2025

PR summary 7c64d37d34

Import changes exceeding 2%

% File
+6.00% Mathlib.Data.Int.Cast.Pi

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Int.Cast.Pi 50 53 +3 (+6.00%)
Mathlib.Algebra.Notation.Pi.Defs 88 89 +1 (+1.14%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Notation.Pi.Defs 1
Mathlib.Data.Int.Cast.Pi 3

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@j-loreaux
Copy link
Copy Markdown
Contributor

Please add to the PR description the list of things you tagged with this (i.e., 1, 0, *, +, ⁻¹, -, star, etc.). That way someone who may look at this PR in the future will easily see which things got tagged without looking at the diff.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2025

✌️ JovanGerb can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 18, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 19, 2025
@JovanGerb
Copy link
Copy Markdown
Contributor Author

JovanGerb commented Oct 19, 2025

I've now searched more consistently for places where this tag would be fitting, so I've tagged many more niche lemmas of the same kind.

@JovanGerb
Copy link
Copy Markdown
Contributor Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 20, 2025
This PR adds the annotations for the tactics `push fun _ ↦ _` and `pull fun _ ↦ _` and the simprocs `pushFun` and `pullFun`.

The following operations are supported: `1`, `0`, `*`, `+`, `⁻¹`, `-`, `/`, `^`, `•`, `+ᵥ`, `-ᵥ`, `star`, `ofNat`, `natCast`, `intCast`, `⊔`, `⊓`, `| |`, `∆`, `⇔`, `⇨`, `⊥`, `⊤`, `ᶜ`, `\`, `default`, `algebraMap`, `kstar`, `⌊/⌋`, `⁺`, `⁻`, `⁺ᵐ`, `⁻ᵐ`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(push): @[push] annotations for fun [Merged by Bors] - feat(push): @[push] annotations for fun Oct 20, 2025
@mathlib-bors mathlib-bors bot closed this Oct 20, 2025
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 24, 2025
This PR adds the annotations for the tactics `push fun _ ↦ _` and `pull fun _ ↦ _` and the simprocs `pushFun` and `pullFun`.

The following operations are supported: `1`, `0`, `*`, `+`, `⁻¹`, `-`, `/`, `^`, `•`, `+ᵥ`, `-ᵥ`, `star`, `ofNat`, `natCast`, `intCast`, `⊔`, `⊓`, `| |`, `∆`, `⇔`, `⇨`, `⊥`, `⊤`, `ᶜ`, `\`, `default`, `algebraMap`, `kstar`, `⌊/⌋`, `⁺`, `⁻`, `⁺ᵐ`, `⁻ᵐ`.
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
This PR adds the annotations for the tactics `push fun _ ↦ _` and `pull fun _ ↦ _` and the simprocs `pushFun` and `pullFun`.

The following operations are supported: `1`, `0`, `*`, `+`, `⁻¹`, `-`, `/`, `^`, `•`, `+ᵥ`, `-ᵥ`, `star`, `ofNat`, `natCast`, `intCast`, `⊔`, `⊓`, `| |`, `∆`, `⇔`, `⇨`, `⊥`, `⊤`, `ᶜ`, `\`, `default`, `algebraMap`, `kstar`, `⌊/⌋`, `⁺`, `⁻`, `⁺ᵐ`, `⁻ᵐ`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants