Skip to content

[Merged by Bors] - feat(Order/Filter/Basic): gcongr for EventuallyEq#29747

Closed
JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-gcongr-EventuallyEq
Closed

[Merged by Bors] - feat(Order/Filter/Basic): gcongr for EventuallyEq#29747
JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-gcongr-EventuallyEq

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

This was originally requested in #mathlib4 > ✔ `rw` with ae relations


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 17, 2025

PR summary 47146f098b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg self-assigned this Sep 17, 2025
@grunweg grunweg changed the title feat(Order/Filter/Basic): gcongr for `EventuallyEq feat(Order/Filter/Basic): gcongr for EventuallyEq Sep 17, 2025
Copy link
Copy Markdown
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

bors merge

BTW, does gcongr already work for Filter.Eventually (and implications)?

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 23, 2025
@JovanGerb
Copy link
Copy Markdown
Contributor Author

Yes, the relevant lemma is Filter.GCongr.eventually_mono. It's still a TODO to not need that auxiliary lemma and tag Filter.Eventually.mono directly.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 23, 2025

Pull request successfully merged into master.

Build succeeded:

  • CI Success

@mathlib-bors mathlib-bors bot changed the title feat(Order/Filter/Basic): gcongr for EventuallyEq [Merged by Bors] - feat(Order/Filter/Basic): gcongr for EventuallyEq Sep 23, 2025
@mathlib-bors mathlib-bors bot closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants