Skip to content

[Merged by Bors] - fix(lint-style): recognise a few more transitive imports of Mathlib.Init as such#29586

Closed
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg:trans-mathlibinit
Closed

[Merged by Bors] - fix(lint-style): recognise a few more transitive imports of Mathlib.Init as such#29586
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg:trans-mathlibinit

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Sep 12, 2025

Uncovered by the fix of CI in #29513.


Commits can be reviewed independently.

Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Sep 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 12, 2025

PR summary 07c736302f

Import changes exceeding 2%

% File
+400.00% Mathlib.Lean.Elab.Tactic.Meta

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Lean.Elab.Tactic.Meta 1 5 +4 (+400.00%)
Import changes for all files
Files Import difference
Mathlib.Lean.Elab.Tactic.Meta 4

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 12, 2025

The CI failure was unrelated: let's see if rebasing on current master also helps.

@grunweg grunweg requested a review from Vierkantor September 12, 2025 11:25
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Sep 12, 2025
…Init` as such (#29586)

Uncovered by the fix of CI in #29513.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(lint-style): recognise a few more transitive imports of Mathlib.Init as such [Merged by Bors] - fix(lint-style): recognise a few more transitive imports of Mathlib.Init as such Sep 12, 2025
@mathlib-bors mathlib-bors bot closed this Sep 12, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…Init` as such (leanprover-community#29586)

Uncovered by the fix of CI in leanprover-community#29513.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
zhuyizheng pushed a commit to zhuyizheng/mathlib4 that referenced this pull request Oct 2, 2025
…Init` as such (leanprover-community#29586)

Uncovered by the fix of CI in leanprover-community#29513.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants