Skip to content

[Merged by Bors] - chore: add two missing Mathlib.Init imports#29585

Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:more-mathlibinit
Closed

[Merged by Bors] - chore: add two missing Mathlib.Init imports#29585
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg:more-mathlibinit

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Sep 12, 2025

Discovered by #29513, which fixes the CI check enforcing these.


Open in Gitpod

@grunweg grunweg requested a review from Vierkantor September 12, 2025 11:08
@grunweg grunweg added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 12, 2025
@github-actions github-actions bot added t-meta Tactics, attributes or user commands large-import Automatically added label for PRs with a significant increase in transitive imports labels Sep 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 12, 2025

PR summary 07c736302f

Import changes exceeding 2%

% File
+1466.67% Mathlib.Tactic.Hint
+4400.00% Mathlib.Tactic.RewriteSearch

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.RewriteSearch 1 45 +44 (+4400.00%)
Mathlib.Tactic.Hint 3 47 +44 (+1466.67%)
Import changes for all files
Files Import difference
Mathlib.Tactic.Hint Mathlib.Tactic.RewriteSearch 44

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Sep 12, 2025

CI fails for unrelated reasons (the .bib file is apparently not normalised). Let me see if rebasing on current master helps...

Discovered by leanprover-community#29513, which fixes the CI check enforcing these.
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Sep 12, 2025
Discovered by #29513, which fixes the CI check enforcing these.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 12, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add two missing Mathlib.Init imports [Merged by Bors] - chore: add two missing Mathlib.Init imports Sep 12, 2025
@mathlib-bors mathlib-bors bot closed this Sep 12, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
Discovered by leanprover-community#29513, which fixes the CI check enforcing these.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
zhuyizheng pushed a commit to zhuyizheng/mathlib4 that referenced this pull request Oct 2, 2025
Discovered by leanprover-community#29513, which fixes the CI check enforcing these.

Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants