[Merged by Bors] - feat: monoid algebras commute with base change#29539
Closed
YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: monoid algebras commute with base change#29539YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 96d819b3dcImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.MonoidAlgebra.Basic | 877 | 942 | +65 (+7.41%) |
Import changes for all files
| Files | Import difference |
|---|---|
6 filesMathlib.Algebra.Category.AlgCat.Basic Mathlib.Algebra.FreeAlgebra Mathlib.Algebra.Star.Free Mathlib.CategoryTheory.Monoidal.Internal.Module Mathlib.LinearAlgebra.SymmetricAlgebra.Basic Mathlib.LinearAlgebra.TensorAlgebra.Basic |
1 |
Mathlib.Algebra.FreeNonUnitalNonAssocAlgebra Mathlib.Algebra.MonoidAlgebra.Basic |
65 |
Mathlib.RingTheory.TensorProduct.MonoidAlgebra (new file) |
1045 |
Declarations diff
+ algebraMap_def
+ algebraMonoidAlgebra
+ instance [CommSemiring T] [Algebra R T] [Algebra S T] [IsScalarTower R S T] :
+ scalarTensorEquiv
+ scalarTensorEquiv_symm_single
+ scalarTensorEquiv_tmul
+ symm_mapRangeAlgEquiv
+ tensorEquiv
+ tensorEquiv_symm_single
+ tensorEquiv_tmul
++ instance [Algebra S B] [Algebra A B] [Algebra R B] [IsScalarTower R A B] [IsScalarTower R S B]
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
plp127
reviewed
Sep 23, 2025
4d0f28e to
6ebc8c7
Compare
Collaborator
|
This pull request has conflicts, please merge |
6ebc8c7 to
adf35de
Compare
erdOne
reviewed
Nov 15, 2025
erdOne
reviewed
Nov 15, 2025
erdOne
reviewed
Nov 15, 2025
erdOne
reviewed
Nov 15, 2025
erdOne
reviewed
Nov 15, 2025
| Warning: This produces a diamond for `Algebra R[M] S[M][M]`. | ||
| That's why it is not a global instance. -/] | ||
| noncomputable abbrev algebraMonoidAlgebra : Algebra (MonoidAlgebra R M) (MonoidAlgebra S M) := | ||
| (mapRangeRingHom M (algebraMap R S)).toAlgebra |
Member
There was a problem hiding this comment.
Note that this discards the SMul field in Algebra R S. Do we care?
Contributor
Author
There was a problem hiding this comment.
I don't think so: there are already other issues for Algebra R[M] R[M]...
Member
|
Also the title doesn't sound right. It seems to be claiming |
From Toric Co-authored-by: Michał Mrugała <kiolterino@gmail.com>
adf35de to
acbd9b1
Compare
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 16, 2025
From Toric Co-authored-by: Michał Mrugała <kiolterino@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Toric
Co-authored-by: Michał Mrugała kiolterino@gmail.com