Skip to content

[Merged by Bors] - feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso on all classes#29451

Closed
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele:wwylele-hahn-archiso
Closed

[Merged by Bors] - feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso on all classes#29451
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele:wwylele-hahn-archiso

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Sep 8, 2025

This will be used in #27268 Hahn embedding theorem

Open in Gitpod

@wwylele wwylele mentioned this pull request Sep 8, 2025
Closed
7 tasks
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2025 •
edited
Loading

PR summary 3eca3de90b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_congrOrderIso_apply
+ congrOrderIso
+ congrOrderIso_symm

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

YaelDillies
YaelDillies approved these changes Sep 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 9, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Sep 9, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 9, 2025

✌️ wwylele can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 9, 2025
@wwylele @YaelDillies
Update Mathlib/Algebra/Order/Archimedean/Class.lean
88ff240 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Sep 9, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Sep 9, 2025
@wwylele
feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso…
4a587d4 
… on all classes (#29451)

This will be used in #27268 Hahn embedding theorem
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso on all classes [Merged by Bors] - feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso on all classes Sep 9, 2025
@mathlib-bors mathlib-bors bot closed this Sep 9, 2025
@wwylele wwylele deleted the wwylele-hahn-archiso branch September 9, 2025 20:43
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
@wwylele @yuanyi-350
feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso…
e5f54a0 
… on all classes (leanprover-community#29451)

This will be used in leanprover-community#27268 Hahn embedding theorem
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
@wwylele @robertmaxton42
feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso…
d4d3cab 
… on all classes (leanprover-community#29451)

This will be used in leanprover-community#27268 Hahn embedding theorem
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@wwylele @joelriou
feat(Algebra/Order): OrderIso on FiniteArchimedeanClass from OrderIso…
81d3d35 
… on all classes (leanprover-community#29451)

This will be used in leanprover-community#27268 Hahn embedding theorem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wwylele @riccardobrasca @YaelDillies