Skip to content

[Merged by Bors] - feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop of embDomain#29421

Closed
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele:wwylele-hahn-embdomain
Closed

[Merged by Bors] - feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop of embDomain#29421
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele:wwylele-hahn-embdomain

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Sep 8, 2025 •
edited
Loading

These will be used in #27268 Hahn embedding theorem

Open in Gitpod

@wwylele wwylele mentioned this pull request Sep 8, 2025
Closed
7 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2025 •
edited
Loading

PR summary 30ce261d23

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ embDomainOrderAddMonoidHom
+ embDomainOrderAddMonoidHom_injective
+ embDomainOrderEmbedding
+ orderTop_embDomain

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Sep 8, 2025
@wwylele wwylele force-pushed the wwylele-hahn-embdomain branch 2 times, most recently from bf5461f to 4cebe04 Compare September 8, 2025 13:29
@wwylele wwylele force-pushed the wwylele-hahn-embdomain branch from 4cebe04 to 1ff1645 Compare September 8, 2025 13:51
YaelDillies
YaelDillies approved these changes Sep 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 9, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Sep 9, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 9, 2025

✌️ wwylele can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 9, 2025
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Sep 9, 2025

Adopted suggestion with a slight tweak: OrderEmbedding doesn't contain monitone' field, so I added toOrderHom there. This changed the @[simps] generated lemma to

HahnSeries.embDomainOrderAddMonoidHom_apply.{u_1, u_2, u_3} {Γ : Type u_1} {R : Type u_2} [LinearOrder Γ]
  [PartialOrder R] {Γ' : Type u_3} [LinearOrder Γ'] (f : Γ ↪o Γ') [AddMonoid R] (a✝ : Lex (HahnSeries Γ R)) :
  (embDomainOrderAddMonoidHom f) a✝ = (embDomainOrderEmbedding f).toOrderHom.toFun a✝

When used in simp, it eventually simps to embDomain f a.

Will merge later if no objection to this change

@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Sep 9, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Sep 9, 2025
@wwylele
feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop…
ed00a78 
… of embDomain (#29421)

These will be used in #27268 Hahn embedding theorem
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop of embDomain [Merged by Bors] - feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop of embDomain Sep 9, 2025
@mathlib-bors mathlib-bors bot closed this Sep 9, 2025
@wwylele wwylele deleted the wwylele-hahn-embdomain branch September 9, 2025 20:43
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
@wwylele @yuanyi-350
feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop…
91d6980 
… of embDomain (leanprover-community#29421)

These will be used in leanprover-community#27268 Hahn embedding theorem
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@wwylele @joelriou
feat(RingTheory/HahnSeries): embDomain as OrderAddMonoidHom; orderTop…
ececb9a 
… of embDomain (leanprover-community#29421)

These will be used in leanprover-community#27268 Hahn embedding theorem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-ring-theory Ring theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wwylele @riccardobrasca @YaelDillies